Page MenuHomeFreeBSD

comms/ncid: Update to 1.6
ClosedPublic

Authored by cpm on Dec 26 2016, 3:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 4:34 AM
Unknown Object (File)
Nov 23 2024, 1:42 AM
Unknown Object (File)
Nov 12 2024, 11:39 AM
Unknown Object (File)
Sep 29 2024, 1:39 PM
Unknown Object (File)
Sep 28 2024, 5:13 AM
Unknown Object (File)
Sep 24 2024, 12:49 PM
Unknown Object (File)
Sep 24 2024, 12:49 PM
Unknown Object (File)
Sep 19 2024, 8:14 PM
Subscribers
None

Details

Summary
comms/ncid: Update to 1.6

- Update ncid to 1.6 release
- Drop maintainership

Changes:
  https://sourceforge.net/p/ncid/news/2016/11/ncid-16-released/
Test Plan
  • portlint -ac output looks fine.
  • poudriere testport build log is fine on 10.3/amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cpm retitled this revision from to comms/ncid: Update to 1.6.
cpm updated this object.
cpm edited the test plan for this revision. (Show Details)
cpm added reviewers: AMDmi3, feld, junovitch.
cpm edited the test plan for this revision. (Show Details)
junovitch edited edge metadata.

LGTM as long as builds on each major release are good.

This revision is now accepted and ready to land.Dec 27 2016, 3:29 AM
comms/ncid/Makefile
21 ↗(On Diff #23277)

Maybe extensions/*.sh setup/*.sh logrotate/*.sh ?

71 ↗(On Diff #23277)

No need to be inside the loop. Maybe also wildcard INSTALL hangup-*.sh?

cpm edited edge metadata.

Add missing installation files.

This revision now requires review to proceed.Dec 27 2016, 6:39 PM
cpm marked 2 inline comments as done.Dec 27 2016, 6:43 PM

New changes have been added.

What do you think about it?

AMDmi3 requested changes to this revision.Dec 28 2016, 6:22 PM
AMDmi3 edited edge metadata.
AMDmi3 added inline comments.
comms/ncid/Makefile
16 ↗(On Diff #23303)

There should be run_depend as long as it installs bash scripts.

68 ↗(On Diff #23303)

This still doesn't belong inside the loop

74 ↗(On Diff #23303)

First, it does not belong to the loop as it does not use ${f}. Next, it only affects one utility while there are 6 of them. Last but not least, applocations should just be installed with ${INSTALL_PROGRAM}, no STRIP_CMD will be needed that way.

96 ↗(On Diff #23303)

These two lines either

113 ↗(On Diff #23303)

This is a script. Install with INSTALL_SCRIPT.

comms/ncid/pkg-plist
40 ↗(On Diff #23303)

Are you sure no one will change these config files? Convert to @sample otherwise.

This revision now requires changes to proceed.Dec 28 2016, 6:22 PM
cpm edited edge metadata.
cpm marked 6 inline comments as done and an inline comment as not done.

Done!

cpm planned changes to this revision.Dec 28 2016, 10:38 PM
cpm added inline comments.
comms/ncid/Makefile
71 ↗(On Diff #23277)

These scripts are installed without *.sh extension.

cpm edited edge metadata.

Re-add shells/bash to BUILD_DEPENDS

Dimitry,

Please, I would appreciate if you could confirm that all changes are fine :)

Thanks

This revision is now accepted and ready to land.Jan 12 2017, 11:25 AM
This revision was automatically updated to reflect the committed changes.
cpm mentioned this in rP431256: - Update to 1.6.