Page MenuHomeFreeBSD

cmake: Do not rely on ${STRIP} for debugging
ClosedPublic

Authored by mva on Sep 30 2014, 7:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 6 2024, 12:35 PM
Unknown Object (File)
Jan 30 2024, 3:50 PM
Unknown Object (File)
Jan 15 2024, 8:02 PM
Unknown Object (File)
Jan 15 2024, 5:36 PM
Unknown Object (File)
Dec 23 2023, 9:50 AM
Unknown Object (File)
Dec 4 2023, 6:55 AM
Unknown Object (File)
Nov 25 2023, 12:50 PM
Unknown Object (File)
Sep 19 2023, 10:08 PM
Subscribers

Details

Reviewers
makc
bapt
Group Reviewers
portmgr
kde
Summary

bsd.ports.mk sets STRIP= after all Uses files have been processed initially.
If you have WITH_DEBUG=yes set, cmake's INSTALL_TARGET has been set already to
install/strip, before STRIP is reset.

The quick fix also evaluates WITH_DEBUG, which should be checked anyways,
since this is the correct user-settable argument, that should have precedence
over implementation details of bsd.port.mk.

Test:

/usr/ports/graphics/openshadinglanguage # make -VWITH_DEBUG -VINSTALL_TARGET
yes
install/strip

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

mva retitled this revision from to cmake: Do not rely on ${STRIP} for debugging.
mva updated this object.
mva edited the test plan for this revision. (Show Details)
mva added reviewers: portmgr, kde.
mva edited edge metadata.
makc added a reviewer: makc.
makc added a subscriber: makc.

looks ok.

bapt added a reviewer: bapt.
This revision is now accepted and ready to land.Oct 2 2014, 7:22 AM