Fix tx power (diff) calculation for rtl8812au/rtl8821au
ClosedPublic
Actions

Authored by kevlo on Nov 18 2016, 9:07 AM.

Details

Reviewers

avos
adrian

Commits

rS308825: For RTL8812AU:

Summary

The diff fixes two bugs for RTL8812AU/RTL8821AU

the Tx power (diff) values should be signed
fix diff calculation; For example, the values of pwr_diff_2g->diff123[0].ofdm_cck and pwr_diff_2g->diff123[0].ht40_ht20 were not calculated

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevlo updated this revision to Diff 22322.Nov 18 2016, 9:07 AM

kevlo retitled this revision from to Fix tx power (diff) calculation for rtl8812au/rtl8821au.

kevlo updated this object.

kevlo edited the test plan for this revision. (Show Details)

kevlo added reviewers: avos, adrian.

adrian accepted this revision.Nov 18 2016, 6:07 PM

adrian edited edge metadata.

This revision is now accepted and ready to land.Nov 18 2016, 6:07 PM

(but definitely get avos@ input before comimtting!)

Yes, this is off-by-one bug. Thanks!

RTL8821AU

It does not use these fields (1T1R); that's why it went unnoticed.

Closed by commit rS308825: For RTL8812AU: (authored by kevlo). · Explain WhyNov 19 2016, 7:28 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

rtwn/

rtl8812a/

r12a_rom.c

19 lines

r12a_var.h

20 lines

Diff 22343

View Options

head/sys/dev/rtwn/rtl8812a/r12a_rom.c