Page MenuHomeFreeBSD
Differential D8541

[iwm] Sync if_iwm_phy_db code with Linux iwlwifi.
Needs ReviewPublic
Actions

Authored by ivadasz on Nov 16 2016, 9:15 PM.
Tags
None
Referenced Files
F151583480: D8541.diff
Thu, Apr 9, 8:16 AM
Unknown Object (File)
Mon, Apr 6, 3:19 PM
Unknown Object (File)
Sun, Apr 5, 1:18 PM
Unknown Object (File)
Mon, Mar 30, 11:30 AM
Unknown Object (File)
Sun, Mar 29, 5:14 PM
Unknown Object (File)
Sat, Mar 28, 5:26 PM
Unknown Object (File)
Fri, Mar 27, 2:51 AM
Unknown Object (File)
Wed, Mar 18, 9:42 AM
View All 79 Files
Subscribers
None

Details

Reviewers
cognet
adrian
Summary

This dynamically allocates some arrays now, which were statically sized
in the existing code from an older iwlwifi version.

Obtained from: DragonFlyBSD

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5965
Build 6243: arc lint + arc unit

Event Timeline

ivadasz updated this revision to Diff 22264.Nov 16 2016, 9:15 PM
ivadasz retitled this revision from to [iwm] Sync if_iwm_phy_db code with Linux iwlwifi..
ivadasz updated this object.
ivadasz added reviewers: adrian, cognet.
adrian edited edge metadata.Nov 16 2016, 9:50 PM

the rest of the patch looks good. let's just change M_DEVBUF to M_IWM and declare a new malloc type.

sys/dev/iwm/if_iwm_phy_db.c
227

please create a M_IWM malloc type so we can easily track this stuff. Having random device stuff in M_DEVBUF makes tracking leaks suck.

Revision Contents
Changeset List

PathSize
sys/
dev/
iwm/
26 lines
12 lines
334 lines
39 lines
21 lines

Diff 22264

View Options

sys/dev/iwm/if_iwm.c

Loading...
View Options

sys/dev/iwm/if_iwm_phy_db.h

Loading...
View Options

sys/dev/iwm/if_iwm_phy_db.c

Loading...
View Options

sys/dev/iwm/if_iwmreg.h

Loading...
View Options

sys/dev/iwm/if_iwmvar.h

Loading...