Page MenuHomeFreeBSD

[net80211] Don't check bgscanidle setting in net80211 for full-offload scan.
ClosedPublic

Authored by ivadasz on Nov 16 2016, 8:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 24 2024, 6:24 AM
Unknown Object (File)
Feb 7 2024, 12:49 AM
Unknown Object (File)
Jan 1 2024, 8:45 AM
Unknown Object (File)
Dec 27 2023, 5:45 PM
Unknown Object (File)
Dec 27 2023, 5:44 PM
Unknown Object (File)
Dec 20 2023, 2:03 AM
Unknown Object (File)
Oct 3 2023, 10:29 PM
Unknown Object (File)
Sep 29 2023, 9:01 AM
Subscribers
None

Details

Summary

If full-offload scan is used, the NIC driver (or rather the firmware of
the NIC) should take care of interrupting and continuing the background
scan. So net80211 should ignore the vap->iv_bgscanidle setting, instead
the NIC driver might look at this setting and pass it on to the firmware
in some way if possible.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivadasz retitled this revision from to [net80211] Don't check bgscanidle setting in net80211 for full-offload scan..
ivadasz updated this object.
ivadasz added reviewers: adrian, avos.
adrian edited edge metadata.
This revision is now accepted and ready to land.Nov 16 2016, 9:50 PM

the NIC driver might look at this setting and pass it on to the firmware in some way if possible.

It can check if (ic->ic_flags_ext & IEEE80211_FEXT_BGSCAN) is non-zero instead; is there any example where this approach can be better? (as I can see, after this change IEEE80211_FEXT_SCAN_OFFLOAD flag will unconditionally disable background scanning - so, every driver (with this flag set) will need to setup parameters in hardware - or, if that's not supported, reimplement the logic instead)

The background scan starting will still happen with this change (if IEEE80211_FEXT_SCAN_OFFLOAD is set, it will just omit the iv_bgscanidle check).
The contbgscan() check will unconditionally return false if IEEE80211_FEXT_SCAN_OFFLOAD is set, because we are no longer interrupting scans (neither normal, nor background) when IEEE80211_FEXT_SCAN_OFFLOAD is set. That's also the reason why checking iv_bgscanidle in net80211 doesn't really make sense in that case, since it wouldn't avoid that the background scan interferes with the wireless traffic anymore.

avos edited edge metadata.

Ok, thanks for the description; I've just misread the code.

This revision was automatically updated to reflect the committed changes.