Details

Reviewers

AMDmi3
junovitch
feld

Commits

rP422218: - Update corebird to 1.3.1 release

Summary

Update corebird to 1.3.1 release

Changelog:

https://github.com/baedert/corebird/releases/tag/1.3.1

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cpm updated this revision to Diff 20104.Sep 6 2016, 8:01 PM

cpm retitled this revision from to net-im/corebird: Update to 1.3.1.

cpm updated this object.

cpm edited the test plan for this revision. (Show Details)

cpm added reviewers: AMDmi3, feld, junovitch.

Good, but additionally I'd

Fix license (GPLv3+), add LICENSE_FILE
Line up options block
Silence all three explicitly called commands

This revision is now accepted and ready to land.Sep 7 2016, 10:36 AM

Done!

Thanks Dmitry :)

This revision now requires review to proceed.Sep 7 2016, 11:14 AM

Oops, I was looking at outdated versions of port locally.

The license does not need to be fixed (it should be GPLv3+)
For options block to be readable, I'd att a tab for GSTREAMER_USE and remove one for GSTREAMER_CONFIGURE_OFF, so whole block is aligned at 3 tabs

AMDmi3 requested changes to this revision.Sep 7 2016, 11:36 AM

AMDmi3 edited edge metadata.

This revision now requires changes to proceed.Sep 7 2016, 11:36 AM

cpm updated this revision to Diff 20136.Sep 7 2016, 11:45 AM

cpm edited edge metadata.

Now perfect!

This revision is now accepted and ready to land.Sep 7 2016, 11:50 AM

Well, now we can watch videos again in corebird. The missing plugin was multimedia/gstreamer1-plugin-hls but due an existing bug in multimedia/gstreamer-plugins-bad [0], corebird crashes.

After applying patch [1] to gstreamer-plugins-bad, corebird works fine.

[0] https://github.com/baedert/corebird/issues/555
[1] https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?h=1.8&id=3aee2039591421f4cc8757353034daf0e011a9ce