Page MenuHomeFreeBSD
Differential D700

Changes to ZFS ARC interation with VM
ClosedPublic
Actions

Authored by smh on Aug 30 2014, 7:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 19, 1:44 PM
Unknown Object (File)
Wed, Feb 19, 12:34 PM
Unknown Object (File)
Thu, Feb 13, 6:38 AM
Unknown Object (File)
Tue, Feb 11, 11:53 PM
Unknown Object (File)
Dec 15 2024, 4:01 AM
Unknown Object (File)
Dec 2 2024, 1:47 AM
Unknown Object (File)
Dec 2 2024, 1:01 AM
Unknown Object (File)
Nov 12 2024, 2:11 AM
View All 68 Files
Subscribers
None

Details

Reviewers
peter
smh
Summary

Ensure that ZFS free memory checks include cached pages

Also restore kmem_used() check for i386 as it has KVA limits that the raw page counts above don't consider

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

smh updated this revision to Diff 1289.Aug 30 2014, 7:36 PM
smh retitled this revision from to Changes to ZFS ARC interation with VM.
smh updated this object.
smh edited the test plan for this revision. (Show Details)
smh added a reviewer: peter.Aug 30 2014, 7:43 PM
peter edited edge metadata.Aug 30 2014, 8:40 PM

By inspection, this appears to address my concerns. I was about to fire up a local preliminary version but I'll use this to keep it simple.

The 1-line change at the kmem_free_count() entry at the top is the one I particularly want.

I believe zfs on i386 (and other non-direct-map, kva-restricted machines) requires more work (eg: the arc_memory_throttle function needs a similar constraint) but I don't want to hold up the fixes for that.

smh added a comment.Aug 30 2014, 11:15 PM

Thanks for the review I've commit this change.

smh accepted this revision.Aug 31 2014, 4:24 PM
smh added a reviewer: smh.
This revision is now accepted and ready to land.Aug 31 2014, 4:24 PM
smh added a comment.Aug 31 2014, 4:27 PM

Peter can you approve the patch so I can close this one off, as there doesn't seem to be a way to force it based on a comment only.

smh closed this revision.Aug 31 2014, 8:51 PM

Revision Contents
Changeset List

PathSize
sys/
cddl/
compat/
opensolaris/
kern/
9 lines
sys/
1 line
contrib/
opensolaris/
uts/
common/
fs/
zfs/
8 lines

Diff 1289

View Options

sys/cddl/compat/opensolaris/kern/opensolaris_kmem.c

Loading...
View Options

sys/cddl/compat/opensolaris/sys/kmem.h

Loading...
View Options

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c

Loading...