Page MenuHomeFreeBSD
Differential D6165

Add requested commercial vendors
ClosedPublic
Actions

Authored by sd_beastie.io on Apr 30 2016, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 12:35 PM
Unknown Object (File)
Wed, Nov 20, 10:38 PM
Unknown Object (File)
Thu, Nov 14, 1:36 PM
Unknown Object (File)
Wed, Nov 13, 10:16 AM
Unknown Object (File)
Tue, Nov 12, 3:25 AM
Unknown Object (File)
Sat, Nov 9, 9:04 PM
Unknown Object (File)
Oct 28 2024, 9:04 PM
Unknown Object (File)
Oct 24 2024, 5:13 AM
View All 93 Files
Subscribers
None

Details

Reviewers
wblock
Commits
rD48844: Update commercial ISP list. Diff to address multiple PRs provided by
Summary

PRs: 207615, 208989, 208919, 208460

Description text are mostly copied verbatim except in one case where we removed a personal reference back to an individual. Wanted to keep it organization oriented.

Ran igor to cleanup newly added section. This file has a ton of igor warnings/errors - filed a new bug to cleanup vendor list along with igor errors (209169).

Test Plan

igor and webbuild

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sd_beastie.io updated this revision to Diff 15773.Apr 30 2016, 4:57 PM
sd_beastie.io retitled this revision from to Add requested commercial vendors.
sd_beastie.io updated this object.
sd_beastie.io edited the test plan for this revision. (Show Details)
sd_beastie.io added a reviewer: wblock.
sd_beastie.io set the repository for this revision to rD FreeBSD doc repository - subversion.
sd_beastie.io updated this object.Apr 30 2016, 5:00 PM
sd_beastie.io updated this revision to Diff 15972.May 6 2016, 4:37 PM

changed Arp Networks to ARP Networks

sd_beastie.io updated this revision to Diff 15973.May 6 2016, 4:41 PM

Remove .com from Delimeter title.

wblock added inline comments.May 20 2016, 9:16 PM
share/xml/commercial.isp.xml
381 ↗(On Diff #15973)

This is a whitespace-only change, and should be not be included with this content change.

1356 ↗(On Diff #15973)

Plural:
s/newspaper/newspapers/

1358 ↗(On Diff #15973)

Use the serial comma:
s/services/services,/

1368 ↗(On Diff #15973)

Use the serial comma:
s/colocation/colocation,/

1380 ↗(On Diff #15973)

This sentence has several problems. It appears to be at least two sentences smushed together.

1385 ↗(On Diff #15973)

Use the serial comma:
s/BSD/BSD,/

1394 ↗(On Diff #15973)

Use the serial comma:
s/NetBSD/NetBSD,/

1395 ↗(On Diff #15973)

Why is "server management" capitalized?

1396 ↗(On Diff #15973)

"&" is for company names and handwritten notes, don't use it here.

1397 ↗(On Diff #15973)

Use the serial comma:
s/PHP/PHP,/

Also needs a space before the opening paren.

1399 ↗(On Diff #15973)

Needs a comma after Columbia.

sd_beastie.io marked 11 inline comments as done.May 23 2016, 6:59 PM

Lesson learned - these texts dont have to be verbatim copies of what the customer provider. Will add new patch soon.

share/xml/commercial.isp.xml
1380 ↗(On Diff #15973)

I was under the impression, perhaps incorrectly, that we were supposed to copy/paste the text verbatim from client. I am re-doing the paragraph to simplify the text.

1395 ↗(On Diff #15973)

As above - I thought this was supposed to copied verbatim from the client :-/

sd_beastie.io updated this revision to Diff 16747.May 23 2016, 8:26 PM
sd_beastie.io marked 2 inline comments as done.

Updated diff based on review comments

sd_beastie.io updated this object.May 23 2016, 8:26 PM
wblock added inline comments.May 23 2016, 10:37 PM
share/xml/commercial.isp.xml
1380 ↗(On Diff #16747)

"tool" needs to be "tools".

1381 ↗(On Diff #16747)

Please remove the comma after "installs".

sd_beastie.io marked 2 inline comments as done.May 24 2016, 12:02 AM
sd_beastie.io added inline comments.
share/xml/commercial.isp.xml
1380 ↗(On Diff #16747)

My bad - VI with special characters display enabled show $ for line ending right after tool: "tool$". Missed that.

1381 ↗(On Diff #16747)

changed to installations instead of installs as well "automated OS installations and dedicated..."

sd_beastie.io updated this revision to Diff 16755.May 24 2016, 12:03 AM
sd_beastie.io marked 2 inline comments as done.

Updated based on review and fix a few more spelling mistakes in the file.

wblock added inline comments.May 24 2016, 3:22 AM
share/xml/commercial.isp.xml
655 ↗(On Diff #16755)

Got one, but missed one: "possibility"

sd_beastie.io updated this revision to Diff 16771.May 24 2016, 4:04 AM

Fix possibility

wblock accepted this revision.May 24 2016, 4:46 PM
wblock edited edge metadata.

Okay, good.

This revision is now accepted and ready to land.May 24 2016, 4:46 PM
Closed by commit rD48844: Update commercial ISP list. Diff to address multiple PRs provided by (authored by wblock). · Explain WhyMay 24 2016, 4:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
share/
xml/
57 lines

Diff 16806

View Options

head/share/xml/commercial.isp.xml

Loading...