Page MenuHomeFreeBSD

Remove LOG_ODELAY because it does nothing.
ClosedPublic

Authored by neel on Aug 15 2014, 3:33 AM.
Tags
None
Referenced Files
F86995748: D611.id1113.diff
Fri, Jun 28, 4:17 AM
Unknown Object (File)
Sun, Jun 23, 10:53 PM
Unknown Object (File)
Sun, Jun 16, 12:42 AM
Unknown Object (File)
May 18 2024, 5:02 PM
Unknown Object (File)
May 18 2024, 8:48 AM
Unknown Object (File)
May 13 2024, 4:09 PM
Unknown Object (File)
Apr 25 2024, 11:04 PM
Unknown Object (File)
Apr 25 2024, 1:59 PM
Subscribers
None

Details

Reviewers
jilles
Test Plan

Install world and boot

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

neel retitled this revision from to Remove LOG_ODELAY because it does nothing..
neel edited the test plan for this revision. (Show Details)
neel added a reviewer: jilles.
jilles requested changes to this revision.Aug 15 2014, 7:35 PM
jilles edited edge metadata.

LOG_ODELAY indeed does nothing and can be removed. However, please apply this change to all non-contrib code to reduce noise: libexec/getty, libexec/rshd, usr.bin/lock, usr.bin/login, usr.sbin/timed/timedc. (It looks safest to treat release/picobsd/tinyware as contrib code given that it has not been touched/tested (?) for a long time.)

This revision now requires changes to proceed.Aug 15 2014, 7:35 PM
neel edited edge metadata.

Remove LOG_ODELAY from non-contrib code.

jilles edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.Aug 16 2014, 11:57 AM