Differential D59723

textproc/libebml: Fix build with utf8cpp 4.x
Needs ReviewPublic
Actions

Authored by olgeni on Wed, Sep 16, 11:03 AM.

Tags

None

Referenced Files

	F172358767: D59723.diff
	Thu, Sep 17, 10:51 PM

	F172256539: D59723.id186839.diff
	Thu, Sep 17, 7:24 AM

	Unknown Object (File)
	Thu, Sep 17, 2:53 AM

	Unknown Object (File)
	Wed, Sep 16, 1:27 PM

Subscribers

Details

Reviewers

None

Group Reviewers

Summary

Since 1.4.6 upstream locates utfcpp via find_package(utf8cpp). Without
a CMake config, it fell back to linking -lutf8cpp and failed. Depend
on the config now installed by devel/utf8cpp, drop the include path
patch made redundant by the imported target, and fix variable order.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 76970
Build 73853: arc lint + arc unit

Event Timeline

olgeni created this revision.Wed, Sep 16, 11:03 AM

olgeni held this revision as a draft.

Harbormaster completed remote builds in B76970: Diff 186839.Wed, Sep 16, 11:03 AM

olgeni added a parent revision: D59722: devel/utf8cpp: Install CMake package config.Wed, Sep 16, 11:03 AM

olgeni published this revision for review.Wed, Sep 16, 8:23 PM

It's already fixed in https://cgit.freebsd.org/ports/commit/?id=4d1b5b445e681e46f1eb91a6b7bd166e47b4be0f

Revision Contents
Changeset List

Path

Size

textproc/

libebml/

8 lines

files/

patch-src_EbmlUnicodeString.cpp

Diff 186839

textproc/libebml/Makefile

Loading...

textproc/libebml/files/patch-src_EbmlUnicodeString.cpp

Loading...