Differential D59490

devel/libvirt: run virt-host-validate in rc script
AcceptedPublic
Actions

Authored by novel on Mon, Sep 7, 4:48 PM.

Tags

None

Referenced Files

	F171030409: D59490.id.diff
	Tue, Sep 8, 7:13 AM

	F171028622: D59490.id186143.diff
	Tue, Sep 8, 6:58 AM

	F171028550: D59490.diff
	Tue, Sep 8, 6:58 AM

	F171019264: D59490.id186143.diff
	Tue, Sep 8, 5:40 AM

	F170992430: D59490.diff
	Tue, Sep 8, 1:41 AM

Subscribers

None

Details

Reviewers

Summary

Update the libvirtd rc script to run virt-host-validate(1)
before running libvirtd(8). This command provides information
about possibly missing kernel modules required for certain
features of libvirtd. Errors and warnings from this tool do not
prevent libvirt(8) from starting as most of the features
are optional.

Suggested by: arrowd
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76638
Build 73521: arc lint + arc unit

Event Timeline

novel requested review of this revision.Mon, Sep 7, 4:48 PM

novel created this revision.

Harbormaster completed remote builds in B76638: Diff 186143.Mon, Sep 7, 4:48 PM

novel added a reviewer: arrowd.Mon, Sep 7, 4:48 PM

arrowd added inline comments.Mon, Sep 7, 4:56 PM

devel/libvirt/files/libvirtd.in
52	Since we're ignoring the return code here, why make the whole check conditional?

novel added inline comments.Mon, Sep 7, 5:20 PM

devel/libvirt/files/libvirtd.in
52	For people who do not want extra noise on their console or logs.

LGTM, thanks.

This revision is now accepted and ready to land.Mon, Sep 7, 5:26 PM

Revision Contents
Changeset List

Path

Size

devel/

libvirt/

1 line

files/

19 lines

Diff 186143

devel/libvirt/Makefile

Loading...

devel/libvirt/files/libvirtd.in

Loading...