This also covers updating all its dependencies, most of which
are only used by www/py-grimoirelab.
Details
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Thanks for the work! At the moment, there's still a issue: py-sortinghat cannot yet be built due conflicting Django versions; see the two inline comments for more details.
| devel/py-sortinghat/Makefile | ||
|---|---|---|
| 18 ↗ | (On Diff #178215) | The build fails at the run_depends stage due conflicting Django versions because py-django-graphql-jwt still uses py-django42 instead py-django52. Switching py-django-graphql-jwt to py-django52 and bumping the PORTREVISION is only the half battle. In addition, a py-dj52-graphene-django port that is bound to Django 5.2 need be created on a temporary basis. Otherwise the build of py-django-graphql-jwt fails at the run_depends stage - due conflicting Django versions as well. Therefore, the approach would be as follows:
|
| 19 ↗ | (On Diff #178215) | As mentioned above, the Django 5.2 counterpart, py-dj52-graphene-django should be placed here. |
Sorry, forgot to add the changes we discussed over email! Split that out in a parent revision in v2.
No worries, all is good.
There’s only one minor issue left to sort out (see inline comment for the devel/py-graal port), and the rest are style/whitespace nits.
| devel/py-graal/files/patch-graal_graal.py | ||
|---|---|---|
| 9 | This should be replaced with %LOCALBASE%/bin/git and %LOCALBASE% itself is then replaced with ${LOCALBASE} via a post-patch target. The math/py-igraph port would be a good example of this. | |
| devel/py-grimoirelab-toolkit/Makefile | ||
| 8 | Is there a reason why the comment was removed in the new version? | |
| 21 | python:3.10+ is a no-op as Python 3.9 is long gone from the ports tree. | |
| devel/py-perceval-opnfv/Makefile | ||
| 8–9 | Trailing whitespace. | |
| devel/py-perceval-puppet/Makefile | ||
| 8–9 | Trailing whitespace. | |
| devel/py-perceval-weblate/Makefile | ||
| 8–9 | Trailing whitespace. | |
| devel/py-perceval/Makefile | ||
| 25 | Is there a reason for the new blank line? | |
| textproc/py-grimoirelab-panels/Makefile | ||
| 8 | Is there a reason why the comment was omitted in the new version? | |
| www/py-grimoirelab/Makefile | ||
| 8 | Is there a reason why the comment was omitted in the new version? | |
| 32 | python:3.10+ is a no-op as Python 3.9 is long gone from the ports tree. | |
We're almost done; there's just one small issue with additional packaged files, but this is something that's often seen with Python ports that are being patched locally.
| devel/py-graal/Makefile | ||
|---|---|---|
| 47 |
| |
| www/py-grimoirelab/Makefile | ||
| 32 |
That probably got lost in the shuffle. :) | |