misc/vxl: Don't override build conflicts by one another
ClosedPublic
Actions

Authored by smyru on Fri, May 15, 1:33 PM.

Details

Reviewers

0mp
yuri

Commits

R11:15f25aa71eeb: misc/vxl: Don't override build conflicts by one another

Summary

Approved by: portmgr blanket
Approved by: 0mp (mentor)

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

smyru requested review of this revision.Fri, May 15, 1:33 PM

smyru created this revision.

Harbormaster completed remote builds in B73126: Diff 177884.Fri, May 15, 1:33 PM

LGTM.

Style nits:

Commit message: I'd go with misc/vxl: Don't override build conflicts by one another. I'd also add a short paragraph saying The second CONFLICTS_BUILD=dcmtk was overriding the first CONFLICTS_BUILD assignment.`.
I'd sort the names listed in the CONFLICTS_BUILD variable. Tip: this is probably handled by portfmt.

Otherwise, it's ready to land.

This revision is now accepted and ready to land.Wed, May 20, 2:12 PM

smyru retitled this revision from misc/vxl: dont override build conflicts by one another to misc/vxl: Don't override build conflicts by one another.Thu, May 21, 8:53 AM

Addressing style notes

This revision now requires review to proceed.Thu, May 21, 8:55 AM

Harbormaster completed remote builds in B73305: Diff 178304.Thu, May 21, 8:55 AM

Thanks!

This revision is now accepted and ready to land.Sat, May 23, 2:26 PM

Closed by commit R11:15f25aa71eeb: misc/vxl: Don't override build conflicts by one another (authored by smyru). · Explain WhySat, May 23, 5:59 PM

This revision was automatically updated to reflect the committed changes.

smyru added a commit: R11:15f25aa71eeb: misc/vxl: Don't override build conflicts by one another.