Page MenuHomeFreeBSD

Drop dependency on security/libgnome-keyring in some gnome3 ports
ClosedPublic

Authored by rm on Mar 20 2016, 9:05 PM.
Tags
Referenced Files
Unknown Object (File)
Dec 24 2023, 7:54 PM
Unknown Object (File)
Dec 23 2023, 12:00 AM
Unknown Object (File)
Dec 14 2023, 3:09 PM
Unknown Object (File)
Nov 30 2023, 12:17 AM
Unknown Object (File)
Nov 25 2023, 3:58 PM
Unknown Object (File)
Nov 23 2023, 2:51 PM
Unknown Object (File)
Nov 16 2023, 6:21 AM
Unknown Object (File)
Nov 13 2023, 10:18 PM
Subscribers

Details

Summary

According to libsecret page libsecret replaces libgnome-keyring, so this is a trend in gnome community, that didn't reflected in our ports tree.

This ports mistakenly depends on deprecated security/libgnome-keyring, while they didn't actually required it or required security/libsecret instead:

  • databases/evolution-data-server
  • net/gnome-online-accounts
  • net/vinagre
  • net/vino
  • www/epiphany
  • security/gnome-keyring
  • x11/gnome-shell
  • x11/gdm

Patch in review resolves all the occurrences of libgnome-keyring. For some ports there are corresponding NEWS entry. For example:

databases/evolution-data-server
./NEWS: * Replaced gnome-keyring-1 with libsecret-1 (since 3.7.1)

net/vinagre
./NEWS: Migrate from libgnome-keyring to libsecret

net/vino
./NEWS: Migrate from libgnome-keyring to libsecret

This was checked both with ldd and manual source code grepping. Now testing in poudriere.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rm retitled this revision from to Drop dependency on security/libgnome-keyring in some gnome3 ports.
rm updated this object.
rm edited the test plan for this revision. (Show Details)
rm set the repository for this revision to rP FreeBSD ports repository.
rm added a project: gnome.
rm updated this object.
x11/gdm/Makefile
96 ↗(On Diff #14457)

Since we always depend on gnome-keyring, how about axing the whole KEYRING options completly.

so the SUB_LIST+= PAM_KEYRING lines and the %%PAM_KEYRING%% keywords, not the lines, can be removed from files/gdm-password.in

pam_gnome_keyring.so is installed by gnome-keyring, so it's always available, but user may not want to use it. This is why I decided to retain the option.

x11/gdm/Makefile
96 ↗(On Diff #14457)

pam_gnome_keyring.so is installed by gnome-keyring, so it's always available, but user may not want to use it. This is why I decided to retain the option.

rm removed rP FreeBSD ports repository as the repository for this revision.

Drop KEYRING option altogether.

kwm edited edge metadata.
This revision is now accepted and ready to land.Mar 20 2016, 10:07 PM

Could you use devel/arcanist to upload the diff, or if you have some allergies to php or something, update the diff using:

svn diff --diff-cmd=diff -x -U9999

So that we get context for the review.

rm edited edge metadata.
rm marked 2 inline comments as done.
This revision now requires review to proceed.Mar 20 2016, 10:34 PM

Reuploadded the diff with svn diff --diff-cmd=diff -x -U9999

x11/gdm/files/gdm-password.in
6 ↗(On Diff #14460)

Should be LOCALBASE or PREFIX here.

x11/gdm/files/gdm-password.in
6 ↗(On Diff #14460)

Good catch. It should be LOCALBASE, since that file is installed by the consolekit port.

This revision was automatically updated to reflect the committed changes.