Page MenuHomeFreeBSD

Do not truncate office phones in finger's summary listing
ClosedPublic

Authored by lidl on Mar 14 2016, 8:57 PM.

Details

Summary

Do not truncate office phones in finger's summary listing

When finger is invoked as as "finger username", it produces the
long listing by default, and phones numbers are pretty-printed
by the prphone() function. When invoked as just "finger", the
same pretty-printing happens, but is truncated at 9 characters.
Given the summary listing is already greater than 80 columns,

Test Plan

compiled and tested on sparc64, amd64

Without the patch:

root@host-251: finger
Login Name TTY Idle Login Time Office Phone
lidl Kurt Lidl pts/0 Feb 26 22:59 +1-xxx-yy
lidl Kurt Lidl pts/1 Mar 3 22:22 +1-xxx-yy

With the patch:
root@host-256: /usr/obj/usr/src/usr.bin/finger/finger
Login Name TTY Idle Login Time Office Phone
lidl Kurt Lidl pts/0 Feb 26 22:59 +1-xxx-yyy-zzzz
lidl Kurt Lidl pts/1 Mar 3 22:22 +1-xxx-yyy-zzzz

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lidl updated this revision to Diff 14321.Mar 14 2016, 8:57 PM
lidl retitled this revision from to Do not truncate office phones in finger's summary listing.
lidl updated this object.
lidl edited the test plan for this revision. (Show Details)
lidl added a reviewer: rpaulo.
rpaulo accepted this revision.Mar 14 2016, 9:51 PM
rpaulo edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2016, 9:51 PM
This revision was automatically updated to reflect the committed changes.