Page MenuHomeFreeBSD

sysutils/watchcat: new port
AcceptedPublic

Authored by antranigv_freebsd.am on Sat, Jan 24, 11:11 PM.
Tags
None
Referenced Files
F143104164: D54863.id170356.diff
Mon, Jan 26, 12:58 AM
F143104027: D54863.id170356.diff
Mon, Jan 26, 12:55 AM
F143093775: D54863.diff
Sun, Jan 25, 10:15 PM
F143093605: D54863.id.diff
Sun, Jan 25, 10:11 PM
F143092026: D54863.id170410.diff
Sun, Jan 25, 9:39 PM
F143089622: D54863.id170409.diff
Sun, Jan 25, 9:08 PM
Unknown Object (File)
Sun, Jan 25, 8:22 PM
Unknown Object (File)
Sun, Jan 25, 7:53 PM
Subscribers

Details

Reviewers
fuz
Summary

watchcat has the best of watch and cat.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 70144
Build 67027: arc lint + arc unit

Event Timeline

fuz added inline comments.
sysutils/watchcat/Makefile
3

Please follow Porter's Handbook example 17 for Github-based ports without versions.

8

WWW is set automatically from GH_PROJECT and GH_ACCOUNT, no need ot set it manually.

15

Instead of packaging a bunch of objects as dependencies, it's probably easier to just download the dependencies in source code and bundle them. We do the same for Rust and Go dependencies. Perhaps just do it the same way you do it in devel/vipack.

19

GH_PROJECT should be omitted if it is identical to PORTNAME.

sysutils/watchcat/pkg-descr
2

Please expand to at least three lines. It is not clear to me what this project does. Also capitalise the beginning of your sentences and use proper punctuation.

Well I learned a lot doing this port. Submitting the new changes now.

  • sysutils/watchcat: delete voc-* deps and use GH_TUPLE
  • sysutils/watchcat: better pkg-descr
  • add watchcat to sysutils/Makefile

Looks better! Here are some minor nits to check.
If there is a test suite, check if you can hook it up.

sysutils/watchcat/Makefile
17–19

Please use full git hashes to avoid collisions if possible.

28

Avoid environment pollution (this change should also be applied to your other port).

Noted! Will diff again with the requested changes. Thank you!!!

sysutils/watchcat/Makefile
28

By other port you mean devel/vipack I assume? I understand MAKE_ENV but what does SETENVI do?

Thank you!

sysutils/watchcat/Makefile
28

SETENVI expands to env -i, clearing all environment variables except for those explicitly supplied. This avoids environment pollution.

  • sysutils/watchcat: delete voc-* deps and use GH_TUPLE
  • sysutils/watchcat: better pkg-descr
  • add watchcat to sysutils/Makefile
  • sysutils/watchcat: improve environment
  • sysutils/watchcat: use full git hash

That should do it! Thank you for all the help!

Will commit with my next batch.

This revision is now accepted and ready to land.Mon, Jan 26, 5:12 PM