editors/poedit PR ports/190974

[rodrigo]

Summary

• add NLS support
• bump PORTREVISION

PR: ports/190974
Submitted by: nikola lecic <[e-mail]>
Approved by: xxx (mentor)

Test Plan

http://www.bebik.net/poudriere/10amd64-svn-commit-tree/2014-08-04_11h48m53s/logs/poedit-1.4.6.1_3.log

[bapt]

if you add support to disable NLS then you do need to add OPTIONS_DEFINE=NLS

[rodrigo]

OPTIONS_DEFINE=NLS removed

http://www.bebik.net/poudriere/10amd64-svn-commit-tree/2014-08-04_16h06m37s/logs/poedit-1.4.6.1_3.log

[bapt]

ok my bad my eyes and/or brain should be doing bad thing your first patch was good you do need OPTIONS_DEFINE and I haven't been able to see it for $reason

Please restart on the first patch, and can you use options helpers instead of the dirty

.include <bsd.port.options.mk>

.if ${PORT_OPTIONS:MNLS}
USES+= gettext
CONFIGURE_ARGS+= --enable-nls
PLIST_SUB+= NLS=""
.else
CONFIGURE_ARGS+= --disable-nls
PLIST_SUB+= NLS="@comment "
.endif

by something like

NLS_USES= gettext
NLS_CONFIGURE_ENABLE= nls
OPTIONS_SUB=yes

[rodrigo]

Rollback and improved. Test check-orphans with & without NLS

http://www.bebik.net/poudriere/10amd64-svn-commit-tree/2014-08-04_23h02m53s/logs/poedit-1.4.6.1_3.log

[rodrigo]

This diff needs bapt approval to be closed
But in the meantime, I land it, thanks

[bapt]

I approved by commit the last modification needed myself :) you can close now :)

[rodrigo]

closed \o/