Page MenuHomeFreeBSD

cad/fdm_materials: Update 5.7.0 => 10.9.0
AcceptedPublic

Authored by alven on Tue, Oct 7, 9:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 1:17 PM
Unknown Object (File)
Sat, Oct 11, 1:17 PM
Unknown Object (File)
Sat, Oct 11, 1:17 PM
Unknown Object (File)
Sat, Oct 11, 5:02 AM
Unknown Object (File)
Fri, Oct 10, 9:46 AM
Unknown Object (File)
Thu, Oct 9, 8:34 PM
Unknown Object (File)
Thu, Oct 9, 3:24 AM
Unknown Object (File)
Thu, Oct 9, 3:15 AM
Subscribers
None

Details

Reviewers
yuri
db
Summary
Test Plan

For every {amd64, i386} × {14.3, 13.5}:

  • Successful poudriere testport
  • Successful run-testing

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 67643
Build 64526: arc lint + arc unit

Event Timeline

alven requested review of this revision.Tue, Oct 7, 9:18 PM
alven created this revision.
alven added a reviewer: db.
cad/fdm_materials/Makefile
3

This line should become these 2 lines:
DISTVERSION= 10.9.0
DISTVERSIONSUFFIX= -0

By -0 they mean "Release", vs. -alphaXX or -betaXX.

Since we normally don't port alpha or beta versions -0 shouldn't make it into the port version.
DISTVERSIONSUFFIX would effectively ignore it.

Thanks for the explanation :) Fixing it now...

Fix DISTVERSION. Add DISTVERSIONSUFFIX.

alven retitled this revision from cad/fdm_materials: Update 5.7.0 => 10.9.0-0 to cad/fdm_materials: Update 5.7.0 => 10.9.0.Wed, Oct 8, 11:17 AM

Approved.

Thanks,
Yuri

This revision is now accepted and ready to land.Wed, Oct 8, 2:01 PM

I still need approval from Diane. Had not hear from her for so long. Hope she will get well soon.

(I meant, she is a maintainer of this port, so I'm to wait for her decision).