Page MenuHomeFreeBSD
Differential D52408

science/cdf: improve and lint port
ClosedPublic
Actions

Authored by alven on Sep 6 2025, 11:33 PM.
Tags
None
Referenced Files
F132068496: D52408.id161691.diff
Mon, Oct 13, 9:27 AM
F132003207: D52408.id.diff
Sun, Oct 12, 9:01 PM
F132003206: D52408.id161663.diff
Sun, Oct 12, 9:01 PM
F132003202: D52408.id161750.diff
Sun, Oct 12, 9:01 PM
F132003189: D52408.id161673.diff
Sun, Oct 12, 9:01 PM
F132003176: D52408.id161693.diff
Sun, Oct 12, 9:01 PM
Unknown Object (File)
Sun, Oct 12, 9:27 AM
Unknown Object (File)
Thu, Oct 9, 9:49 AM
View All 38 Files
Subscribers
None

Details

Reviewers
db
yuri
alven
Commits
R11:b3ef01b8ab07: science/cdf: improve and lint port
Summary
  • Lint and sort Makefile according to portclippy(1)
  • Mark as PIE_UNSAFE
  • Split post-install stance to respect DOCS and EXAMPLES options
  • Strip installed binaries and libs
  • Use dynamic SOVERSION via PLIST_SUB
Test Plan

For every {amd64, i386} × {14.3, 13.5}:

  • Successful poudriere testport
  • Successful run-testing

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alven requested review of this revision.Sep 6 2025, 11:33 PM
alven created this revision.
Harbormaster completed remote builds in B66863: Diff 161663.Sep 6 2025, 11:33 PM
alven updated this revision to Diff 161673.Sep 7 2025, 12:40 PM

Add forgotten PORTREVISION bump

Harbormaster completed remote builds in B66867: Diff 161673.Sep 7 2025, 12:40 PM
yuri added inline comments.Sep 7 2025, 8:00 PM
science/cdf/Makefile
60

Missing blank line before this and the other target.

alven added a comment.Sep 7 2025, 8:53 PM

Thank you, Yuri: you know that I would be glad to have my ports perfect :)

alven updated this revision to Diff 161691.Sep 7 2025, 8:54 PM

Add missing blank lines separating post-install stances

Harbormaster completed remote builds in B66877: Diff 161691.Sep 7 2025, 8:54 PM
alven marked an inline comment as done.Sep 7 2025, 8:54 PM
yuri added a comment.Sep 7 2025, 8:58 PM

Approved.

alven signed these changes with MFA.Sep 7 2025, 9:18 PM
alven accepted this revision.
This revision is now accepted and ready to land.Sep 7 2025, 9:18 PM
alven updated this revision to Diff 161693.Sep 7 2025, 9:36 PM

Sorry, after final pre-commit check I see make test is still unable to find libcdf.so.0

Hope it will be useful even without this fix

This revision now requires review to proceed.Sep 7 2025, 9:36 PM
Harbormaster completed remote builds in B66879: Diff 161693.Sep 7 2025, 9:36 PM
alven edited the summary of this revision. (Show Details)Sep 7 2025, 9:37 PM
alven retitled this revision from science/cdf: fix, improve and lint port to science/cdf: improve and lint port.
This revision was not accepted when it landed; it landed in state Needs Review.Sep 8 2025, 10:12 PM
Closed by commit R11:b3ef01b8ab07: science/cdf: improve and lint port (authored by alven). · Explain Why
This revision was automatically updated to reflect the committed changes.
alven added a commit: R11:b3ef01b8ab07: science/cdf: improve and lint port.

Revision Contents
Changeset List

PathSize
science/
cdf/
30 lines
2 lines

Diff 161750

View Options

science/cdf/Makefile

Loading...
View Options

science/cdf/pkg-plist

Loading...