New port devel/py-delfick_error
ClosedPublic
Actions

Authored by truckman on Feb 9 2016, 10:04 AM.

Details

Reviewers

Commits

rP408600: New port devel/py-delfick_error:

Summary

The point of this exception class is to be able to create
an error class that automatically combines keyword arguments
given to the exception instance.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

truckman updated this revision to Diff 13145.Feb 9 2016, 10:04 AM

truckman retitled this revision from to New port devel/py-delfick_error.

truckman updated this object.

truckman edited the test plan for this revision. (Show Details)

truckman added a reviewer: koobs.

Inline suggestion to use direct test invocation (rather than through script)

Otherwise LGTM.

devel/py-delfick_error/Makefile
43 ↗	(On Diff #13145)	Prefer to invoke tests directly We'll be providing python.mk framework variables for this soon, so it will assist in the conversion process Same ordered do-test recommended as the previous review Your call if you want to change this or not, but highly desirable.

This revision is now accepted and ready to land.Feb 9 2016, 10:08 AM

It is too late for me to commit this tonight ...

No such thing! :D

been on front of this screen for most of the last 20 hours ... ZZZ ...

devel/py-delfick_error/Makefile
43 ↗	(On Diff #13145)	cd /wrkdirs/usr/ports/devel/py-delfick_error/work/delfick_error-6761e6c && /usr/local/bin/python2.7 test.sh File "test.sh", line 2 nosetests --with-noy $@ ^ SyntaxError: invalid syntax