Page MenuHomeFreeBSD

devel/git - Lighten perl dependencies
ClosedPublic

Authored by adamw on Feb 3 2016, 9:55 PM.

Details

Summary

See bug#206901. The perl hooks only require p5-Error, and the other two modules (which bring in a half dozen other modules) are only used for git-send-email(1).

This patch adds a SEND_EMAIL option (which auto-enables the PERL option) and conditionalizes the git-send-email script installation.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

adamw retitled this revision from to devel/git - Lighten perl dependencies.
adamw updated this object.
adamw edited the test plan for this revision. (Show Details)
adamw added a reviewer: garga.
adamw set the repository for this revision to rP FreeBSD ports repository.
garga edited edge metadata.

It looks good to me. If it passes all tests with poudriere go ahead and commit it.

This revision is now accepted and ready to land.Feb 4 2016, 9:59 AM

It changes the default package because the git-send-email(1) script (and the other perl modules) were installed by default before. Should SEND_EMAIL default to off (changes default package), or on (default package stays the same)?

Please leave the option enabled by default since it's a common used feature

This revision was automatically updated to reflect the committed changes.