Reported by: bofh
Details
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 63971 Build 60855: arc lint + arc unit
Event Timeline
I have tested and it works as intended.
devel/py-structlog/Makefile | ||
---|---|---|
18 | The EOL \ is not required here and is superfluous. This must be removed. | |
20 | This is a requirement only when the python version is less than 3.11. In a recent commit I have added a variable PY_TYPING_EXTENSIONS so you can use that like RUN_DEPENDS= ${PY_TYPING_EXTENSIONS} or do a conditional check like after .include <bsd.port.pre.mk>: .if ${PYTHON_REL} < 31100 RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}typing-extensions>=4.12.2:devel/py-typing-extensions@${PY_FLAVOR} .endif | |
27 | Try to pet portclippy. |
No. I have added the variable in HEAD. So from python 3.11 it is part of official python so no need to include this on python 3.11. What I did was:
. if ${PYTHON_REL} < 31100 PY_EXCEPTIONGROUP= ${PYTHON_PKGNAMEPREFIX}exceptiongroup>=1.1.1:devel/py-exceptiongroup@${PY_FLAVOR} PY_TOMLI= ${PYTHON_PKGNAMEPREFIX}tomli>=2.0.2<3:textproc/py-tomli@${PY_FLAVOR} * PY_TYPING_EXTENSIONS= ${PYTHON_PKGNAMEPREFIX}typing-extensions>0:devel/py-typing-extensions@${PY_FLAVOR} . endif
So PY_TYPING_EXTENSIONS will only be populated when python version is less than 3.11. And this is the exact case for at least this port. The pyproject.toml at least says that this is required only when python is less than 3.11. There are other ports where this is not the case and py-typing-extensions is mandatory and this variable should not be used.
devel/py-structlog/Makefile | ||
---|---|---|
20 |
|