Page MenuHomeFreeBSD

devel/py-structlog: update to 25.3.0
AbandonedPublic

Authored by dch on May 4 2025, 9:52 PM.
Tags
None
Referenced Files
F121038892: D50151.id154806.diff
Mon, Jun 23, 3:27 AM
Unknown Object (File)
Sun, Jun 15, 9:04 PM
Unknown Object (File)
Thu, Jun 5, 9:27 PM
Unknown Object (File)
Wed, May 28, 9:31 PM
Unknown Object (File)
May 21 2025, 10:03 PM
Unknown Object (File)
May 20 2025, 1:24 AM
Subscribers
None

Details

Reviewers
bofh
dch
Summary

Reported by: bofh

Test Plan

NB only manually built via make, my poudriere is blocked on other ports atm

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63971
Build 60855: arc lint + arc unit

Event Timeline

dch requested review of this revision.May 4 2025, 9:52 PM
dch created this revision.
bofh requested changes to this revision.May 5 2025, 2:40 PM

I have tested and it works as intended.

devel/py-structlog/Makefile
18

The EOL \ is not required here and is superfluous. This must be removed.

20

This is a requirement only when the python version is less than 3.11. In a recent commit I have added a variable PY_TYPING_EXTENSIONS so you can use that like RUN_DEPENDS= ${PY_TYPING_EXTENSIONS} or do a conditional check like after .include <bsd.port.pre.mk>:

.if ${PYTHON_REL} < 31100
RUN_DEPENDS+=	${PYTHON_PKGNAMEPREFIX}typing-extensions>=4.12.2:devel/py-typing-extensions@${PY_FLAVOR}
.endif
27

Try to pet portclippy.

This revision now requires changes to proceed.May 5 2025, 2:40 PM
dch marked an inline comment as done.May 6 2025, 4:56 PM
dch added inline comments.
devel/py-structlog/Makefile
18

thanks, I left this behind before sorting!

20

so PY_TYPING_EXTENSIONS is built-in (at least in ports) to
newer pythons?

No. I have added the variable in HEAD. So from python 3.11 it is part of official python so no need to include this on python 3.11. What I did was:

  .  if ${PYTHON_REL} < 31100
  PY_EXCEPTIONGROUP=      ${PYTHON_PKGNAMEPREFIX}exceptiongroup>=1.1.1:devel/py-exceptiongroup@${PY_FLAVOR}
  PY_TOMLI=       ${PYTHON_PKGNAMEPREFIX}tomli>=2.0.2<3:textproc/py-tomli@${PY_FLAVOR}
* PY_TYPING_EXTENSIONS=   ${PYTHON_PKGNAMEPREFIX}typing-extensions>0:devel/py-typing-extensions@${PY_FLAVOR}
  .  endif

So PY_TYPING_EXTENSIONS will only be populated when python version is less than 3.11. And this is the exact case for at least this port. The pyproject.toml at least says that this is required only when python is less than 3.11. There are other ports where this is not the case and py-typing-extensions is mandatory and this variable should not be used.

devel/py-structlog/Makefile
20

so PY_TYPING_EXTENSIONS is built-in (at least in ports) to
newer pythons?

dch marked 2 inline comments as done.May 6 2025, 5:05 PM

include bofh recommendations