Page MenuHomeFreeBSD

umass: Remove some 20-year-old dead code
ClosedPublic

Authored by imp on Mar 10 2025, 7:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 23, 9:49 AM
Unknown Object (File)
Aug 30 2025, 1:16 PM
Unknown Object (File)
Aug 6 2025, 12:34 AM
Unknown Object (File)
Jul 28 2025, 12:09 PM
Unknown Object (File)
Jul 25 2025, 12:15 AM
Unknown Object (File)
Jul 24 2025, 6:37 PM
Unknown Object (File)
Jul 24 2025, 5:21 AM
Unknown Object (File)
Jul 22 2025, 4:22 PM
Subscribers
None

Details

Summary

A REQUEST SENSE CDB was just copied into the cmd buffer, so testing for
INQUIRY will always fail. Remove the dead code.

This code was added, apparently by mistake in 2003. 8541fbec7900e
merged changes from NetBSD's umass_scsipi.c 1.8 to address some BBB
bulk-in clear problems. NetBSD had fixed a problem in the
FORCE_SHORT_INQUIRY quirk code they had ported from FreeBSD that FreeBSD
also needed. That merge also included the dead code, which was not in
NetBSD.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Mar 10 2025, 7:19 PM
imp created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2025, 2:35 AM
This revision was automatically updated to reflect the committed changes.