Page MenuHomeFreeBSD

infiniband: fix a possible use-after-free bug
Needs ReviewPublic

Authored by emaste on Thu, Mar 6, 3:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 7, 6:14 AM
Unknown Object (File)
Fri, Mar 7, 5:52 AM
Unknown Object (File)
Fri, Mar 7, 4:54 AM
Subscribers
None
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary
ucma_process_join() will free the new allocated "mc" struct,
if there is any error after that, especially the copy_to_user().

But in parallel, ucma_leave_multicast() could find this "mc"
through idr_find() before ucma_process_join() frees it, since it
is already published.

So "mc" could be used in ucma_leave_multicast() after it is been
allocated and freed in ucma_process_join(), since we don't refcnt
it.

Fix this by separating "publish" from ID allocation, so that we
can get an ID first and publish it later after copy_to_user().

Fixes: c8f6a362bf3e ("RDMA/cma: Add multicast communication support")
Reported-by: Noam Rathaus <noamr@beyondsecurity.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Thu, Mar 6, 3:03 PM
emaste created this revision.