Page MenuHomeFreeBSD

lang/python{27,3*}: Backport upstream issue 20397 patches
ClosedPublic

Authored by koobs on Jan 8 2016, 1:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 22, 2:59 PM
Unknown Object (File)
Wed, May 22, 11:46 AM
Unknown Object (File)
Sun, May 19, 9:18 AM
Unknown Object (File)
Sun, May 19, 9:18 AM
Unknown Object (File)
Sun, May 19, 2:33 AM
Unknown Object (File)
Jan 1 2024, 1:54 AM
Unknown Object (File)
Aug 20 2023, 6:37 PM
Unknown Object (File)
Aug 10 2023, 7:34 PM
Subscribers

Details

Summary

Commit log:

lang/python{27,3*}: Backport patch in upstream issue20397

In certain situations, file references (.py[co]) for Python files that
fail to compile with compileall() are still added to distutils --record
output.

This output is used for pkg-plist generation and must only contain
references to files that will be installed.

One example of a failure condition is when a Python 2/3 compatible
package containing a file containing Python 3.x only code is built with
Python 2.x, such as Gunicorn's _gaiohttp.py [1]

This change backports patches submitted against upstream issue 20397 [2]
that has not yet been committed.

 - For Python 2.7 and 3.5, backport both install_lib and test
 - For Python 3.2, 3.3 and 3.4, only backport install_lib

[1] https://svnweb.freebsd.org/changeset/ports/404558
[2] https://bugs.python.org/issue20397

Thank you to Brendan Molloy for producing the patches against upstream

MFH:		2016Q1
Reviewed by:
DiffRev:	D4832
Test Plan
  • portlint: OK (no changes, i want to keep this backport commit isolated for MFH)
  • testport: OK (poudriere, 11amd64, 102amd64, 93i386)
  • gunicorn: OK (test www/py-gunicorn no longer fails without r404558 workaround)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

koobs retitled this revision from to lang/python{27,3*}: Backport upstream issue20397 patch.
koobs updated this object.
koobs edited the test plan for this revision. (Show Details)
koobs added a subscriber: Python.
koobs retitled this revision from lang/python{27,3*}: Backport upstream issue20397 patch to lang/python{27,3*}: Backport upstream issue 20397 patches.Jan 8 2016, 1:07 PM
koobs edited the test plan for this revision. (Show Details)
sbz added a reviewer: sbz.
sbz added a subscriber: sbz.

LGTM

This revision is now accepted and ready to land.Jan 8 2016, 4:17 PM
koobs edited edge metadata.
koobs updated this object.
miwi added a reviewer: miwi.
miwi added a subscriber: miwi.

Well done!