net-mgmt/smokeping ports/192037

[rodrigo]

Summary

Fix a minima the plugin breakage with Net::DNS 0.75 and above.
Must be fixed by upstream.
https://rt.cpan.org/Public/Bug/Display.html?id=96479

Test Plan

http://www.bebik.net/poudriere/10amd64-svn-commit-tree/2014-07-23_01h14m16s/logs/smokeping-2.6.9_2.log

[kwm]

Hmm the 512 was what &Net::DNS::PACKETSZ did previous?

But if I read the bug the correct way is to dynamicly set the variable but that is probably for later. I think this patch is a good workaround until a proper fix is made upstream.

[rodrigo]

does this mean "approved" ?

[kwm]

Almost :)

I guess I should have asked what your thoughts where on my reasoning.

[rodrigo]

[..] But if I read the bug the correct way is to dynamicly set the variable but that is probably for later

right, but this should be submitted upstream to the smokeping project. The bug is not OS specific.
I don't know how far we have to go to fix the issue, but it can imply design changes. At the moment a small workaround is more suitable

[..] I think this patch is a good workaround

Yes, the patch fix the issue cased by the function removal. In the original patch the submitter suggest an hard-coded value,
I prefer the constants vs magic numbers.

[rodrigo]

landed thanks ?