Details
- Reviewers
bofh diizzy - Commits
- R11:a341e9e64cb7: mail/mutt: Update to 2.2.13
Poudriere testport done.
Portlint, portfmt are ok, portclippy reports a warning of unknown GNU_CONFIGURE_MANPREFIX variable.
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Planned commit message:
mail/mutt: update to 2.2.13
Changelog: https://marc.info/?l=mutt-users&m=170998444711121&w=2
PR: 277604
Reported by: dereks@lifeofadishwasher.com (maintainer)
Approved by: ...
Differential Revision: https://reviews.freebsd.org/D44293
Just in case you miss the other mail:
- Commit with git commit --author NAME <email>
- Remove Reported by:
- Use Approved by: Submitter is maintainer
Okay. I forgot this mail :(
For clarification, the commit message:
mail/mutt: Update to 2.2.13
Changelog: https://marc.info/?l=mutt-users&m=170998444711121&w=2
PR: 277604
Approved by: Submitter is maintainer
Differential Revision: https://reviews.freebsd.org/D44293
- commit message end ---
So, don't you appear in "approved by" in similar cases?
And should commit with:
git commit --author "Derek Schrock <dereks@lifeofadishwasher.com>"
After it pull --ff-only, rebase and push.
Oh damn. I simply forgot you are still under mentorship. :)
Change it to : Approved by: Submitter is maintainer, bofh (mentor), dizzy (mentor) like this
If you already have committed then you need to amend the commit and not create a new commit. Which will be something like:
git commit --amend --author "Derek Schrock <dereks@lifeofadishwasher.com>"
In plain sight it's difficult to grab the changes. But you will see this name somewhere in the commit message as Author.
Let me know if there are multiple commits then you intend to push and this is not the latest commit in the queue then you will need some more work.
:)
If you already have committed then you need to amend the commit and not create a new commit. Which will be something like:
git commit --amend --author "Derek Schrock <dereks@lifeofadishwasher.com>"In plain sight it's difficult to grab the changes. But you will see this name somewhere in the commit message as Author.
Let me know if there are multiple commits then you intend to push and this is not the latest commit in the queue then you will need some more work.
I don't make commits only after approval. I make on my own branch "git diff --output file.diff", "git restore" and if it's approved use "git apply". I feel it safer as the commits.