x11/libei: convert BASU option to subpackage

[jbeich]

Summary

Probably not very useful in practice until xwayland-devel options are flavorized and the ports framework supports provides/requires to propagate flavorized dependencies into consumers.

Test Plan

$ poudriere testport -j 132i386 x11/libei
[...]
===========================================================================
=>> Checking shared library dependencies
 0x00000001 NEEDED               Shared library: [libc.so.7]
 0x00000001 NEEDED               Shared library: [libei.so.1]
 0x00000001 NEEDED               Shared library: [libepoll-shim.so.0]
 0x00000001 NEEDED               Shared library: [libevdev.so.2]

$ poudriere testport -j 132i386 x11/libei~basu
[...]
===========================================================================
=>> Checking shared library dependencies
 0x00000001 NEEDED               Shared library: [libbasu.so.0]
 0x00000001 NEEDED               Shared library: [libc.so.7]
 0x00000001 NEEDED               Shared library: [libepoll-shim.so.0]

[pizzamig]

x11/libei/Makefile

33

Would it make sense to remove the BASU option?
We are encouraging to limit the amount of OPTIONS attached to SUBPACKAGES.
If BASU is not carrying too many dependencies, I would consider to always build it.

38–41

Is basu subpackage independent or does it need the main package to be available as well?

if libei-basu needs libei, you would need to add

SELF_DEPENDS.basu= main

[jbeich]

x11/libei/Makefile

33

• Removing BASU may break LICENSES_REJECTED=GPLv2 builds (via poudriere with OPTIONS_UNSET+=BASU)
• Breaks consistency with other consumers where BASU hasn't been or may not be possible to convert to subpackage
• Deprecating OPTIONS in favor of SUBPACKAGES hasn't been discussed on ports@ list yet

38–41

According to TEST PLAN above liboeffis.so doesn't depend on libei.so. It uses DBus to talk an EIS (Emulated Input Server) where the client may be inside a jail/sandbox.

[pizzamig]

It looks good to me.

x11/libei/Makefile

33

Not suggesting to "deprecate" OPTIONS in favor of SUBPACKAGES.
Just exploring the opportunity to remove an OPTION.
From your answer, the BASU option need to stay

[pizzamig]

Don´t you need an additional pkgdescr.basu?

[jbeich]

Will re-land after bug 276783 is fixed. D43079 example is no better:

$ poudriere bulk -j 132amd64 -a
[...]
[00:02:22] Calculating ports order and dependencies
[00:02:30] Error: compute_deps_pkg failed to lookup pkgname for ports-mgmt/subpkgtest~cmd2 processing package port-test2-0.0.1 from ports-mgmt/subpkgtest2 -- Is SUBDIR+=subpkgtest missing in ports-mgmt/Makefile?
[00:02:30] Error: compute_deps_pkg failed to lookup pkgname for ports-mgmt/subpkgtest~docs processing package port-test2-0.0.1 from ports-mgmt/subpkgtest2 -- Is SUBDIR+=subpkgtest missing in ports-mgmt/Makefile?
[00:02:30] Error: compute_deps_pkg failed to lookup PKGNAME for ports-mgmt/subpkgtest~cmd2 processing package port-test2-0.0.1
[00:02:35] Error: Fatal errors encountered calculating dependencies
[...]