sysutils/terraform: Update to 1.7.0

[dutra]

Summary

Poudriere log:
https://poudriere.nulldutra.me/data/latest-per-pkg/terraform/1.7.0/

Portlint:

WARN: Makefile: Consider defining LICENSE.
0 fatal errors and 1 warning found.

The cause of the error is because the license BUSL not exist in the ports framework.

Commit log:

Author: Gabriel M. Dutra <[e-mail]>
Date:   Sat Jan 20 00:21:10 2024 -0300

commit 540baa09da299bc63409788d7bfa51f7d1180f20 (HEAD -> main)
Author: Gabriel M. Dutra <[e-mail]>
Date:   Thu Jan 25 00:02:20 2024 -0300

    sysutils/terraform: Update to 1.7.0

    Input validations are being restored to the state file in this version
    of Terraform. Due to a state interoperability issue (#33770) in earlier
    versions, users that require interaction between different minor
    series should ensure they have upgraded to the following patches:

      - Users of Terraform prior to 1.3.0 are unaffected
      - Terraform 1.3 series users should upgrade to 1.3.10
      - Terraform 1.4 series users should upgrade to 1.4.7
      - Terraform 1.5 series users should upgrade to 1.5.7
      - Users of Terraform 1.6.0 and later are unaffected

    Full changeLog:
    https://github.com/hashicorp/terraform/releases/tag/v1.7.0

    Approved by:    dbaio(mentor), garga(mentor)
    Differential Revision:  https://reviews.freebsd.org/D43521

[dbaio]

Hello Gabriel.

Could you please share your build logs for all supported releases, including 15-CURRENT?
It is recommended to set the DEVELOPER make(1) variable in /etc/make [1]; please ensure it is configured.

Regarding the changelog part in the commit message, different developers have different practices—some include full or partial text, while others add just the link (similar to myself). There is no right or wrong approach.

Consider the importance of the message you added. If it is crucial for all users upgrading to this new version, there are other places to include it. Refer to the 'UCL in pkg-message' chapter [2] of the porters-handbook.

Also, check the 'UPDATING and MOVED' chapter [3], which is informative for you at this moment, although not applicable in this case.

1 - https://docs.freebsd.org/en/books/porters-handbook/quick-porting/
2 - https://docs.freebsd.org/en/books/porters-handbook/pkg-files/#porting-message
3 - https://docs.freebsd.org/en/books/porters-handbook/upgrading/#moved-and-updating-files

[dutra]

In D43521#992482, @dbaio wrote:

Hello Gabriel.

Could you please share your build logs for all supported releases, including 15-CURRENT?
It is recommended to set the DEVELOPER make(1) variable in /etc/make [1]; please ensure it is configured.

Regarding the changelog part in the commit message, different developers have different practices—some include full or partial text, while others add just the link (similar to myself). There is no right or wrong approach.

Consider the importance of the message you added. If it is crucial for all users upgrading to this new version, there are other places to include it. Refer to the 'UCL in pkg-message' chapter [2] of the porters-handbook.

Also, check the 'UPDATING and MOVED' chapter [3], which is informative for you at this moment, although not applicable in this case.

1 - https://docs.freebsd.org/en/books/porters-handbook/quick-porting/
2 - https://docs.freebsd.org/en/books/porters-handbook/pkg-files/#porting-message
3 - https://docs.freebsd.org/en/books/porters-handbook/upgrading/#moved-and-updating-files

Hi, Danilo!

I updated the summary with poudriere logs and portlint output.

In this case, adding a pkg-message is unnecessary because the context advises users to upgrade minor versions, especially when they employ multiple versions for testing Terraform codes. However, this practice is not applicable in production settings since the state does not support different versions of Terraform.

The port lang/go does no support building on QEMU

https://cgit.freebsd.org/ports/tree/lang/go-devel/Makefile#n17

.ifdef QEMU_EMULATING
IGNORE=                fails to build with qemu-user-static
.endif

Poudriere logs: https://poudriere.nulldutra.me/data/latest-per-pkg/terraform/1.7.0/