Page MenuHomeFreeBSD
Differential D4312

mfh: Use a fall back for $EDITOR before invoking it.
AbandonedPublic
Actions

Authored by rakuco on Nov 29 2015, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 26, 3:12 PM
Unknown Object (File)
Tue, Sep 16, 5:05 PM
Unknown Object (File)
Tue, Sep 16, 3:09 PM
Unknown Object (File)
Tue, Sep 16, 12:10 PM
Unknown Object (File)
Tue, Sep 16, 9:56 AM
Unknown Object (File)
Tue, Sep 16, 9:30 AM
Unknown Object (File)
Tue, Sep 16, 8:59 AM
Unknown Object (File)
Sep 6 2025, 6:09 AM
View All 26 Files
Subscribers
None

Details

Reviewers
None
Group Reviewers
portmgr
Summary

Do the ${EDITOR:-vi} expansion separately from invoking ${EDITOR}, so that the latter into multiple parameters if necessary.

Test Plan

I have EDITOR set to emacs -nw. With this change I can just call the mfh script without getting an error like ./Tools/scripts/mfh: emacs -nw: not found.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1330
Build 1335: arc lint + arc unit

Event Timeline

rakuco updated this revision to Diff 10563.Nov 29 2015, 7:11 PM
rakuco retitled this revision from to mfh: Use a fall back for $EDITOR before invoking it..
rakuco updated this object.
rakuco edited the test plan for this revision. (Show Details)
rakuco added a reviewer: portmgr.
rakuco edited the test plan for this revision. (Show Details)Nov 29 2015, 7:11 PM
rakuco abandoned this revision.Nov 29 2015, 7:26 PM

Hmm, I thought it had worked in my tests, but it still fails due to IFS="${LF}" in the beginning. I'll take a deeper look and redo it.

Revision Contents
Changeset List

PathSize
Tools/
scripts/
3 lines

Diff 10563

View Options

Tools/scripts/mfh

Loading...