Page MenuHomeFreeBSD

Add finalize-{fetch,extract,patch,..} subtargets
Needs RevisionPublic

Authored by AMDmi3 on Nov 21 2015, 1:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 10 2024, 12:46 AM
Unknown Object (File)
Jan 20 2024, 8:56 AM
Unknown Object (File)
Dec 23 2023, 8:32 AM
Unknown Object (File)
Dec 22 2023, 3:11 PM
Unknown Object (File)
Nov 7 2023, 6:49 PM
Unknown Object (File)
Nov 6 2023, 4:36 PM
Unknown Object (File)
Oct 6 2023, 5:40 PM
Unknown Object (File)
Oct 5 2023, 3:33 PM
Subscribers

Details

Reviewers
mat
Group Reviewers
portmgr
Summary

After option-dependent targets have been introduced, there's need for target which runs after all options-dependent ones. Example usecases of such a thing are:

  • Strip all binaries and libraries (where each option-dependent do-install-XXX-on installs subset of files)
  • Finish pkg-message which is composed of chunks dependent on options

This patch intruduces finalize-{fetch,extract,patch,configure,build,install,test} which may be used just like do-/pre-/post- counterparts and are run after all these.

Most common usecase is when upstream `make install' is called, then ther's a bunch of post-install-XXX which install additional stuff, and there's need to post-process (for example, strip) all file installed that way.

The patch contains bsd.port.mk changes and also modifications for two ports which demostrate use of finalize-*

Test Plan
  • Built these two ports and confirmed finalize actions are called.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1241
Build 1245: arc lint + arc unit

Event Timeline

AMDmi3 retitled this revision from to Add finalize-{fetch,extract,patch,..} subtargets.
AMDmi3 updated this object.
AMDmi3 edited the test plan for this revision. (Show Details)

Please, keep the variables in the _SEQ variables at the end.

mat requested changes to this revision.Nov 21 2015, 7:38 PM
mat added a reviewer: mat.

Please, keep the variables in the _SEQ variables at the end.

This revision now requires changes to proceed.Nov 21 2015, 7:38 PM

Also, why not run the post-install targets later using the TARGET_ORDER_OVERRIDE mechanism for the two ports that needs it ?