devel/asfml: New Port, ASFML, Ada bindings to SFML

[agh_riseup.net]

Summary

Ada's Simple and Fast Multimedia Library (ASFML)

ASFML is an Ada semi-thick binding to SFML. The library uses Ada types,
and portable defined types, which eliminates the inclusion of Ada
interface libraries, however most of the functions are directly
imported.

[diizzy]

devel/asfml/Makefile

23

${PORTNAME:tu} ?

45

Use EXAMPLES_RUN_DEPENDS

50

You can use this trick instead and reduce I/O
https://cgit.freebsd.org/ports/tree/net-mgmt/netdata/Makefile#n29

56

Common practice is to use %% (double) --> %%DATA_AUDIO%% (see Porters Handbook)

[agh_riseup.net]

Updated diff in response to dizzy's feedback:

• Use of ${PORTNAME:tu} over hard-coding ASFML
• Move to ${EXAMPLES_RUN_DEPENDS} and remove if if ${PORT_OPTIONS:MEXAMPLES}

conditional

• Make use of ${EXTRACT_AFTER_ARGS} over ${RM} in post-extract target
• Use %% over % for patch file substitution, respecting the practice set out in the Porter's Handbook

[agh_riseup.net]

All suggestions should be addressed in the updated diff.
Thanks for the review.

devel/asfml/Makefile

23

Great idea, done, thanks.

45

So obvious. Fixed.

50

Oh nice pro tip; fixed.

56

Respected.

[diizzy]

LGTM, thanks for your contributions!