Page MenuHomeFreeBSD

getpatch: Do not error out if a patch has a custom encoding.
ClosedPublic

Authored by rakuco on Jul 13 2014, 12:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 4:45 PM
Unknown Object (File)
Wed, Sep 17, 9:47 AM
Unknown Object (File)
Sep 11 2025, 4:22 AM
Unknown Object (File)
Sep 4 2025, 11:08 AM
Unknown Object (File)
Sep 3 2025, 8:38 PM
Unknown Object (File)
Jul 28 2025, 4:06 PM
Unknown Object (File)
Jul 28 2025, 3:52 PM
Unknown Object (File)
Jun 25 2025, 6:10 PM
Subscribers
None

Details

Reviewers
sbz
Summary

Some patches, such as one of the ones sent in 189248, has a custom encoding, so the details page says "foo.diff (text/plain; charset=windows-1250)" instead of just "foo.diff (text/plain)". This made _extract_patchs_name() fail without any further explanation.

Make the regexp more flexible by accepting a charset entry after the mime-type in the details.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rakuco retitled this revision from to getpatch: Do not error out if a patch has a custom encoding..
rakuco updated this object.
rakuco edited the test plan for this revision. (Show Details)
rakuco added a reviewer: sbz.
Tools/scripts/getpatch
123

Another possibility is matching \(text/plain instead of \(text/plain\) to accept anything coming after that.

sbz edited edge metadata.

Committed in r362667 . Thanks!

This revision is now accepted and ready to land.Jul 23 2014, 12:18 PM