Page MenuHomeFreeBSD

getpatch: Do not error out if a patch has a custom encoding.
ClosedPublic

Authored by rakuco on Jul 13 2014, 12:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 21, 10:52 AM
Unknown Object (File)
Sat, Apr 18, 10:10 PM
Unknown Object (File)
Fri, Apr 10, 6:03 AM
Unknown Object (File)
Wed, Apr 8, 12:41 AM
Unknown Object (File)
Sun, Apr 5, 3:42 PM
Unknown Object (File)
Mar 17 2026, 1:56 PM
Unknown Object (File)
Feb 23 2026, 8:16 PM
Unknown Object (File)
Feb 7 2026, 7:10 PM
Subscribers
None

Details

Reviewers
sbz
Summary

Some patches, such as one of the ones sent in 189248, has a custom encoding, so the details page says "foo.diff (text/plain; charset=windows-1250)" instead of just "foo.diff (text/plain)". This made _extract_patchs_name() fail without any further explanation.

Make the regexp more flexible by accepting a charset entry after the mime-type in the details.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rakuco retitled this revision from to getpatch: Do not error out if a patch has a custom encoding..
rakuco updated this object.
rakuco edited the test plan for this revision. (Show Details)
rakuco added a reviewer: sbz.
Tools/scripts/getpatch
123

Another possibility is matching \(text/plain instead of \(text/plain\) to accept anything coming after that.

sbz edited edge metadata.

Committed in r362667 . Thanks!

This revision is now accepted and ready to land.Jul 23 2014, 12:18 PM