Page MenuHomeFreeBSD

databases/postgresql??-*: fix build when using LLVM binutils
Needs ReviewPublic

Authored by emaste on Apr 15 2023, 10:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 6:45 PM
Unknown Object (File)
Wed, Nov 6, 11:34 AM
Unknown Object (File)
Mon, Oct 28, 10:41 PM
Unknown Object (File)
Tue, Oct 22, 12:09 PM
Unknown Object (File)
Oct 15 2024, 10:53 PM
Unknown Object (File)
Oct 14 2024, 8:42 PM
Unknown Object (File)
Sep 23 2024, 11:47 PM
Unknown Object (File)
Sep 23 2024, 11:47 PM
Subscribers
None

Details

Reviewers
girgen
Summary

pgsql's build has requested to strip all non-global symbols (strip -x), but there is at least one non-global symbol that in fact cannot be stripped because it is referenced by a relocation.

Both GNU strip and ELF Tool Chain strip silently handle this case (and just retain the local symbol), but LLVM strip is stricter and emits an error upon request to strip a non-removable local symbol.

There is an LLVM ticket open for this at https://github.com/llvm/llvm-project/issues/47468, and it may make sense for LLVM strip to behave the same as GNU and ELF Tool Chain strip. That said, pgsql should just not use strip -x when there are symbols that cannot be stripped.

PR: 270769

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270769

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.