Page MenuHomeFreeBSD

www/{*chromium,iridium}: unbreak build with icu 73
ClosedPublic

Authored by rnagy on Apr 13 2023, 7:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 13 2024, 2:33 PM
Unknown Object (File)
Nov 4 2023, 11:39 AM
Unknown Object (File)
Nov 4 2023, 11:39 AM
Unknown Object (File)
Nov 3 2023, 8:26 PM
Unknown Object (File)
Nov 3 2023, 6:59 AM
Unknown Object (File)
Oct 1 2023, 3:55 PM
Unknown Object (File)
Oct 1 2023, 3:55 PM
Unknown Object (File)
Sep 29 2023, 7:23 PM
Subscribers

Details

Reviewers
rene
dhw
Summary

As of icu 73 C++ nullptr, char16_t, override, final and noexcept are used
instead of defines. These definitions can be removed when the bundled icu
gets updated to 73. For more details, see:
https://unicode-org.atlassian.net/browse/ICU-21833 and
https://github.com/unicode-org/icu/commit/28643799377ecf654564f6f31854b02788cebe33

Fixes 270817

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rnagy requested review of this revision.Apr 13 2023, 7:41 PM
rnagy created this revision.

In the commit log, can you prefix the PR number with "PR: " so that the commit is logged in the PR?

This revision is now accepted and ready to land.Apr 13 2023, 8:40 PM
dhw added a subscriber: dhw.

After applying the patch to my ports tree (at main-n615777-7e591c4f2380), my poudriere-devel package-builder was able to build www/chromium successfully; the resulting package installed on my laptop and appears to run as usual.