Page MenuHomeFreeBSD

comms/fldigi - fix build with clang
ClosedPublic

Authored by shurd on Jul 4 2014, 10:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 4:47 PM
Unknown Object (File)
Dec 5 2024, 8:45 AM
Unknown Object (File)
Nov 30 2024, 5:00 AM
Unknown Object (File)
Nov 10 2024, 10:21 AM
Unknown Object (File)
Nov 7 2024, 9:25 AM
Unknown Object (File)
Oct 22 2024, 6:33 AM
Unknown Object (File)
Oct 7 2024, 12:35 AM
Unknown Object (File)
Oct 6 2024, 11:41 PM
Subscribers
None

Details

Summary

Fix hashmap macro test to compile with Clang

Commit with: MFH: 2014Q3

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

shurd retitled this revision from to comms/fldigi - fix build with clang.
shurd updated this object.
shurd added reviewers: db, skreuzer.
skreuzer edited edge metadata.

Approved. Thanks

This revision is now accepted and ready to land.Jul 7 2014, 12:33 PM

I'd double check the configure.ac script here before sending fix upstream.
e.g. configure was modified to look for std::hash etc. to make it non specific to GCC or Clang since one of my earlier diffs I sent upstream was too specific.

Looking at configure.ac for example.

    1. std::hash or alternatives
  1. Set ac_cv_std_hash or ac_cv_std_tr1_hash to yes/no
  2. Define HAVE_STD_HASH or HAVE_STD_TR1_HASH in config.h
  3. Substitute BOOST_CPPFLAGS and BOOST_LDFLAGS in Makefile
  4. if falling back to Boost

AC_FLDIGI_HASH

That's my only concern. Approved of course.

shurd updated this revision to Diff 633.

Closed by commit rP361113 (authored by @shurd).