cam: better ioctl compatibility for cd
Needs ReviewPublic
Actions

Authored by imp on May 24 2022, 9:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 9, 1:41 PM

	Unknown Object (File)
	Wed, May 6, 10:33 PM

	Unknown Object (File)
	Fri, May 1, 12:56 PM

	Unknown Object (File)
	Wed, Apr 29, 6:21 PM

	Unknown Object (File)
	Sat, Apr 25, 8:47 AM

	Unknown Object (File)
	Mon, Apr 20, 12:27 AM

	Unknown Object (File)
	Sat, Apr 18, 10:34 PM

	Unknown Object (File)
	Apr 11 2026, 12:38 PM

View All Files

Subscribers

None

Details

Reviewers

None

Group Reviewers

cam

Summary

Unlike xpt and pass driver, there's no test for ENOTTY in cdioctl to try
the compatbility ioctls. Add one.

However, this is a disk ioctl, not a cdev ioctl. To get around this, we
cast the struct disk * to a struct cdev * to pass through. We cast it
back in a simple wrapper function.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45699
Build 42587: arc lint + arc unit

Event Timeline

imp created this revision.May 24 2022, 9:50 PM

Herald added a reviewer: cam. · View Herald TranscriptMay 24 2022, 9:50 PM

imp requested review of this revision.May 24 2022, 9:50 PM

Harbormaster completed remote builds in B45698: Diff 106346.May 24 2022, 9:51 PM

more direct call

Harbormaster completed remote builds in B45699: Diff 106347.May 24 2022, 10:07 PM

imp mentioned this in rG028b16e2088a: cam: better ioctl compatibility for cd.Jul 25 2024, 4:49 AM

Revision Contents
Changeset List

Path

Size

sys/

cam/

cam_compat.c

6 lines

scsi/

scsi_cd.c

24 lines

Diff 106347

View Options

sys/cam/cam_compat.c