Page MenuHomeFreeBSD

Update CONFLICTS check to cover all variables and checks performed by bsd.port.mk
Needs ReviewPublic

Authored by se on Oct 29 2021, 3:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 1:15 AM
Unknown Object (File)
Tue, Apr 16, 1:15 AM
Unknown Object (File)
Tue, Apr 16, 1:14 AM
Unknown Object (File)
Tue, Apr 16, 1:14 AM
Unknown Object (File)
Tue, Apr 9, 12:32 PM
Unknown Object (File)
Mar 19 2024, 4:32 PM
Unknown Object (File)
Feb 22 2024, 10:24 AM
Unknown Object (File)
Feb 13 2024, 1:50 AM
Subscribers
None

Details

Reviewers
marcus
Summary

The CONFLICTS specification checks did cover only a subset of relevant cases:

  • Only CONFLICTS was checked, but CONFLICTS_BUILD and CONFLICTS_INSTALL are also relevant
  • The comparison was only against the full package name, but the actual conflicts check compares with $P{KGBASE} too.
Test Plan

Add a self-conflicting entry to CONFLICTS_BUILD or CONFLICTS_INSTALL and verify that this conflict is now detected.
Test as patterns both the package name with some version pattern and the package name without the version part.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

se requested review of this revision.Oct 29 2021, 3:09 PM
se created this revision.

This looks good, but please do not commit to portlint directly. I will incorporate this into an upcoming release. Thanks.

This revision is now accepted and ready to land.Oct 29 2021, 3:28 PM

Update previous patch to include a check for redundant "-[0-9]*" version patterns in CONFLICTS entries.
I have removed those endings from 388 ports in ports commit 819f25b36d45b8, and this check is meant to prevent those version patterns from re-occurring ...

This revision now requires review to proceed.Oct 30 2021, 7:21 PM

Update previously added check for redundant "-[0-9]*" endings of CONFLICTS patterns.
The warning should not be printed if the preceding FATAL error condition has been triggered.

Thanks. Working on this today. I noticed your latest addition had fancy quotes in it, but I've pulled those out.