- fix shebang lines;
- add a -o option that makes no changes but prints the files that would be updated/created;
- allow the -l argument (and therefore DOC_LANG) to be whitespace separated, comma separated, or a mixture of both
Details
Details
- Reviewers
blackend dbaio - Group Reviewers
doceng - Commits
- R9:c4db9c153e46: tools/books*py: improve argument handling of DOC_LANG, and others
- chmod +x ./tools/books-toc-creator.py; ./tools/books-toc-creator.py -l en
- python3 ./tools/books-toc-creator.py -o -l en,es,hu
- python3 ./tools/books-toc-creator.py -l en,fr de ja el,it python3 ./tools/books-toc-creator.py -l en,fr de ja el,it -o zh-cn
Diff Detail
Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This kind of option remembers something with verbose and dry run options.
I've tested here and this seems fine.
Out of curiosity, is this for help debugging Makefile changes/improvements?
Comment Actions
Out of curiosity, is this for help debugging Makefile changes/improvements?
The DOC_LANG restores previous behaviour documented in make.conf (or share/examples/make.conf, I can’t check at the moment) and white space separated variables are arguably easier to work with in make.
The -o option is a start at reintroducing proper dependency tracking, so that the python targets can stop being .PHONY and incremental builds can come back.