Page MenuHomeFreeBSD

[New Port] sysutils/py-honcho
ClosedPublic

Authored by loader on Jul 10 2015, 3:23 PM.

Details

Summary

poudriere log: http://p.defau.lt/?z__uq5r9RusFSOxiRgrPQg

% portlint -AC
WARN: Makefile: [21]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
0 fatal errors and 1 warning found.

the unit test requires running /usr/local/bin/honcho,
I used install target for regression-test.

Thanks,
loader

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

loader retitled this revision from to [New Port] sysutils/py-honcho.
loader updated this object.
loader edited the test plan for this revision. (Show Details)
loader added a reviewer: koobs.

sorry, ran arc in the wrong directory. update the patch.

koobs requested changes to this revision.Jul 11 2015, 12:35 AM
koobs edited edge metadata.

Test can't be run at install or post installation time unfortunately. Just leave it as regression-test: for now without a build target

Should be fixed upstream along with hooking up the setuptools test command

This revision now requires changes to proceed.Jul 11 2015, 12:35 AM
loader edited edge metadata.

removed install target from regression-test:

koobs edited edge metadata.

LGTM Fukang, ship it!

This revision is now accepted and ready to land.Jul 11 2015, 6:36 AM
This revision was automatically updated to reflect the committed changes.