kern/intr: remove maxirqs from isrc_alloc_irq()
AbandonedPublic
Actions

Authored by ehem_freebsd_m5p.com on Mar 18 2021, 5:04 PM.

Tags

None

Referenced Files

	F148256766: D29326.diff
	Mon, Mar 16, 8:15 PM

	Unknown Object (File)
	Sun, Mar 15, 3:27 PM

	Unknown Object (File)
	Fri, Mar 6, 4:12 PM

	Unknown Object (File)
	Fri, Mar 6, 9:50 AM

	Unknown Object (File)
	Fri, Mar 6, 12:27 AM

	Unknown Object (File)
	Wed, Mar 4, 5:13 PM

	Unknown Object (File)
	Wed, Mar 4, 5:13 PM

	Unknown Object (File)
	Dec 28 2025, 4:52 PM

View All 81 Files

Subscribers

imp

Contributor Reviews (src)

Details

Reviewers: None

Summary

This merely served as an unsigned alias of intr_nirq. The value should
never be negative, nor should it become large enough to overflow. As
such maxirqs mostly serves to confuse, rather than being useful.

Ideally maxirqs would have been removed near
248f0cabca75f421553633184b5bf2ffa459d3de.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37915
Build 34804: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Mar 18 2021, 5:04 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMar 18 2021, 5:04 PM

ehem_freebsd_m5p.com requested review of this revision.Mar 18 2021, 5:04 PM

Harbormaster completed remote builds in B37915: Diff 85970.Mar 18 2021, 5:04 PM

ehem_freebsd_m5p.com mentioned this in D29327: kern/intr: declare interrupt vectors unsigned.Mar 19 2021, 9:34 PM

I think this one is likely to be abandoned as I suspect it will be subsumed by another.

Changes to other commits overlapped this enough to make it no longer worthwhile as a separate commit.

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_intr.c

11 lines

Diff 85970

View Options

kern/intr: remove maxirqs from isrc_alloc_irq()AbandonedPublicActions