Page MenuHomeFreeBSD

Update multimedia/audacious to 4.0.4 and flavorize
ClosedPublic

Authored by madpilot on Jul 8 2020, 11:34 AM.

Details

Reviewers
madpilot
Group Reviewers
portmgr
Commits
rP541716: - Update audacious to 4.0.4
Summary

I'd like to update audacious to 4.0.4.

With this release upstream discontinued the gtk3 UI and is moving to qt. [1]

Due to this I decided to remove the -gtk3 ports and make the qt/gtk2 versions in flavors.

Default set to qt5 since this is the one upstream is considering it's main version now.

I'm also taking maintainership, and so seeking approval due to adding flavors.

[1] https://redmine.audacious-media-player.org/boards/1/topics/2489?r=2500#message-2500

Test Plan

Builds fine in pooudriere with various OPTIONS combinations and both flavors work fine.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 32203
Build 29700: arc lint + arc unit

Event Timeline

P.S. the date in MOVED is just a random guess, will be updated at actual time of commit.

Update patch to merge common USE_GNOME parts.

multimedia/audacious-plugins/Makefile
145–156

I would rather you split this in two, put the bits about everything but options before the OPTIONS block, and then put this just after the OPTIONS_DEFINE/DEFAULT lines :

.if ${FLAVOR} == gtk2
OPTIONS_DEFINE+=	AOSD OPENGL
OPTIONS_DEFAULT+=	AOSD
.endif
multimedia/audacious/Makefile
57–58

Please put this before the OPTIONS block

Accept the flavoring bits.

Accept so I can close it.

This revision is now accepted and ready to land.Jul 9 2020, 8:40 AM