Page MenuHomeFreeBSD

www/py-google-api-python-client: Change RUN_DEPENDS of DJANGO option
AbandonedPublic

Authored by kai on Jun 25 2020, 9:23 AM.

Details

Reviewers
nivit
Group Reviewers
Python
Summary
* Switch the non-default DJANGO option from Django 1.11 (End-of-Life since
  April) to Django 2.2 (current LTS release).

  Because the port itself still has some Python 2.7 consumers and Django 2.2
  requires Python 3.5+, make the DJANGO option invisible when the port is built
  for Python 2.7.

* Bump PORTREVISION due changed dependencies.

PR: 247115
Reviewed: TBA
Test Plan
  • FLAVOR=py27 make config -> DJANGO option not visible
  • make config -> DJANGO option visible
  • FLAVOR=py27 make -V RUN_DEPENDS with DJANGO option set -> www/py-django22 not present in RUN_DEPENDS
  • make -V RUN_DEPENDS with DJANGO option set -> www/py-django22 present in RUN_DEPENDS
  • poudriere bulk -n -a with/without DJANGO option set -> OK, no errors

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

kai requested review of this revision.Jun 25 2020, 9:23 AM
kai created this revision.
koobs added inline comments.
www/py-google-api-python-client/Makefile
28–29

Why did we use a GROUP here?

40

Might we consider only adding the DJANGO option in the > 3.5 case ?

Might be a bit cleaner and explicit than the hoop jumping constructs needed to remove and option

Abandon this revision because the workaround for Python 2.7 is no longer needed since rP559531.

At this point, thank you again @koobs for your time and feedback.