Page MenuHomeFreeBSD

sysutils/amazon-ssm-agent: update to v2.3.1205.0
ClosedPublic

Authored by samm on Sun, May 17, 8:49 PM.

Details

Summary
  • Update amazon-ssm-agent to the latest version
  • Add patch related to goimports run (part of the official build tools)
Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

samm requested review of this revision.Sun, May 17, 8:49 PM
samm created this revision.
samm edited the summary of this revision. (Show Details)Sun, May 17, 8:50 PM
samm set the repository for this revision to rP FreeBSD ports repository.
samm edited the test plan for this revision. (Show Details)Sun, May 17, 8:52 PM
samm edited the test plan for this revision. (Show Details)Sun, May 17, 8:57 PM
cperciva added inline comments.Sun, May 17, 9:03 PM
sysutils/amazon-ssm-agent/files/patch-agent_plugins_inventory_gatherers_application_dataProvider__unix__test.go
9 ↗(On Diff #71895)

Why?

sysutils/amazon-ssm-agent/files/patch-agent_session_utility_utility__unix.go
7 ↗(On Diff #71895)

Do we still need this patch? We're creating the user at package install time so I think we might get the right (non)behaviour out of the box already.

samm updated this revision to Diff 71900.Sun, May 17, 10:10 PM
  • remove not needed patches, set version using own tool
samm added a comment.Mon, May 18, 8:57 PM

@cperciva please let me know if it looks good now for you

sysutils/amazon-ssm-agent/files/patch-agent_plugins_inventory_gatherers_application_dataProvider__unix__test.go
9 ↗(On Diff #71895)

Let me check if we can drop this one, it was from goimports -w

sysutils/amazon-ssm-agent/files/patch-agent_session_utility_utility__unix.go
7 ↗(On Diff #71895)

I think its fine to drop it, will do. Also i found much better way to set version instead of using patch

cperciva accepted this revision.Mon, May 18, 9:08 PM

Looks good, thanks! You can commit this, right?

This revision is now accepted and ready to land.Mon, May 18, 9:08 PM
This revision was automatically updated to reflect the committed changes.