darktable: Fix undefined behaviour with float/int conversions
ClosedPublic
Actions

Authored by dumbbell on Apr 16 2015, 10:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Feb 24, 8:36 PM

	Unknown Object (File)
	Mon, Feb 24, 2:54 PM

	Unknown Object (File)
	Mon, Feb 24, 2:37 PM

	Unknown Object (File)
	Mon, Feb 24, 11:38 AM

	Unknown Object (File)
	Wed, Feb 12, 9:06 PM

	Unknown Object (File)
	Tue, Feb 11, 6:10 PM

	Unknown Object (File)
	Wed, Feb 5, 8:30 AM

	Unknown Object (File)
	Dec 5 2024, 4:21 AM

View All 81 Files

Subscribers

None

Details

Reviewers

kwm

Commits

rP384169: graphics/darktable: Fix bug with preferences when built with Clang 3.6

Summary

The added patch fixes a bug with darktable preferences dialog. The current code relies on GCC's decision regarding an undefined behaviour with float/inv conversions. It is almost working with Clang up-to 3.5 but is broken with Clang 3.6.

The patch will be committed upstream shortly.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell updated this revision to Diff 4863.Apr 16 2015, 10:09 PM

dumbbell retitled this revision from to darktable: Fix undefined behaviour with float/int conversions.

dumbbell updated this object.

dumbbell edited the test plan for this revision. (Show Details)

dumbbell added a reviewer: kwm.

kwm accepted this revision.Apr 17 2015, 8:13 AM

kwm edited edge metadata.

This revision is now accepted and ready to land.Apr 17 2015, 8:13 AM

Closed by commit rP384169 (authored by @dumbbell).

Revision Contents
Changeset List

Path

Size

head/

graphics/

darktable/

Makefile

1 line

files/

patch-tools_generate__prefs.xsl

13 lines

Diff 4886

View Options

head/graphics/darktable/Makefile