Page MenuHomeFreeBSD

darktable: Fix undefined behaviour with float/int conversions
ClosedPublic

Authored by dumbbell on Apr 16 2015, 10:09 PM.

Details

Summary

The added patch fixes a bug with darktable preferences dialog. The current code relies on GCC's decision regarding an undefined behaviour with float/inv conversions. It is almost working with Clang up-to 3.5 but is broken with Clang 3.6.

The patch will be committed upstream shortly.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

dumbbell updated this revision to Diff 4863.Apr 16 2015, 10:09 PM
dumbbell retitled this revision from to darktable: Fix undefined behaviour with float/int conversions.
dumbbell updated this object.
dumbbell edited the test plan for this revision. (Show Details)
dumbbell added a reviewer: kwm.
kwm accepted this revision.Apr 17 2015, 8:13 AM
kwm edited edge metadata.
This revision is now accepted and ready to land.Apr 17 2015, 8:13 AM
dumbbell closed this revision.Apr 17 2015, 6:54 PM
dumbbell updated this revision to Diff 4886.

Closed by commit rP384169 (authored by @dumbbell).