Page MenuHomeFreeBSD

Porter's Handbook: add hint about use of REINPLACE
Needs ReviewPublic

Authored by linimon on Jan 5 2020, 9:48 PM.

Details

Reviewers
mat
Group Reviewers
portmgr
Summary

Add a trivial hint about using REINPLACE: avoid using comma as the delimiter. (This can mess up e.g. CFLAGS modifications.)

Diff Detail

Repository
rD FreeBSD doc repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

linimon created this revision.Jan 5 2020, 9:48 PM
linimon updated this revision to Diff 66391.Jan 5 2020, 10:28 PM

Eliminate lines that belong to D19239.

mat added a comment.Tue, Jan 28, 9:03 PM

REINPLACE does not exist.

This comes out of nowhere, one wonders what uses cases it is trying to fix.

Hints usually comes by the form of a <tip> tag, and it usually goes along where something is defined. In this case, it should go in https://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html in 4.4.3. Simple Automatic Replacements.