Add BROKEN_RUBYxx to simplify Makefile
ClosedPublic
Actions

Authored by sunpoet on Apr 6 2015, 2:43 PM.

Details

Reviewers

Group Reviewers

Ruby
portmgr

Summary

With these new knob, we could simplify Makefile and only include bsd.port.mk once (instead of twice).

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

sunpoet updated this revision to Diff 4698.Apr 6 2015, 2:43 PM

sunpoet retitled this revision from to Add BROKEN_RUBYxx to simplify Makefile.

sunpoet updated this object.

sunpoet edited the test plan for this revision. (Show Details)

Herald added a reviewer: portmgr. · View Herald TranscriptApr 6 2015, 2:43 PM

sunpoet added a reviewer: Ruby.Apr 6 2015, 2:43 PM

swills added a subscriber: swills.Jun 15 2015, 7:04 PM

swills added inline comments.

Mk/bsd.ruby.mk
217	One issue with this, it's not always that something won't build with a particular ruby version, sometimes it builds but doesn't work. So the reason for marking it BROKEN varies.

sunpoet added inline comments.Jun 15 2015, 7:15 PM

Mk/bsd.ruby.mk
217	In this case, use "BROKEN_RUBY22=builds fine but does not work with ruby22" instead. It will set BROKEN in line 219.

Ok, sorry, I missed that. Looks fine. Trying to decide if we need and exp-run for this...

It is quite a simple patch. I guess we do not need exp-run. :)

Yeah, you're right, it is really simple. Approved.

This revision is now accepted and ready to land.Jun 17 2015, 6:00 PM

commited by sunpoet in rP395539

Revision Contents
Changeset List

Path

Size

Mk/

bsd.ruby.mk

8 lines

databases/

rubygem-memcache/

Makefile

9 lines

Diff 4698

View Options

Mk/bsd.ruby.mk