Page MenuHomeFreeBSD

new port dns/py-wdns
ClosedPublic

Authored by truckman on Apr 1 2015, 7:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 4:13 PM
Unknown Object (File)
Mar 4 2024, 2:54 PM
Unknown Object (File)
Mar 4 2024, 2:54 PM
Unknown Object (File)
Mar 4 2024, 2:50 PM
Unknown Object (File)
Mar 4 2024, 2:50 PM
Unknown Object (File)
Mar 4 2024, 2:50 PM
Unknown Object (File)
Mar 3 2024, 8:04 PM
Unknown Object (File)
Feb 27 2024, 6:43 AM
Subscribers
None

Details

Reviewers
mat
Summary

This is pywdns, a Python extension module implemented in Cython
for the wdns C library.

Test Plan

Fetch distfile from both master sites.

Build on FreeBSD 8.4 9.3 10.1 and 11.0-CURRENT, i386 and amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

truckman retitled this revision from to new port dns/py-wdns.
truckman updated this object.
truckman edited the test plan for this revision. (Show Details)
truckman added a reviewer: mat.
mat requested changes to this revision.Apr 1 2015, 9:06 PM
mat edited edge metadata.
mat added inline comments.
dns/py-wdns/Makefile
3 ↗(On Diff #4580)

I think this should be called pywdns, and be in dns/py-pywdns. I know it feels strange but we try very hard to have our packages named the same way as the original software, and there are already a lot of ports named py-py*:

$ ls -ld */py-py*|wc -l
     105
23 ↗(On Diff #4580)

Is this needed ? isn't setup.py already ran through python in python.mk ?

This revision now requires changes to proceed.Apr 1 2015, 9:06 PM
dns/py-wdns/Makefile
23 ↗(On Diff #4580)

You are correct. I was getting an error because env wasn't able to find python. This was the first thing instance that I found when I was looking for the source of the problem, but the problem was actually due to the file that I found that I needed to patch on line 24.

If I nuke line 23, I still get a successful build.

truckman edited edge metadata.

Change PORTNAME to pywdns.

Use MASTER_SITE_FARSIGHT

Nuke unneeded ${REINPLACE_CMD}

truckman edited edge metadata.

... and rename the directory to match PORTNAME

Tested with make index

dns/py-pywdns/Makefile
7–8

Would fit on one line.

Collapse MASTER_SITES to a single line.

Add LICENSE_FILE

dns/py-pywdns/Makefile
13

/usr/local/share/licenses/py27-pywdns-0.6.0/APACHE20 now contains:

Copyright (c) 2009-2014 by Farsight Security, Inc.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

Does that look correct?

mat edited edge metadata.

Looks good to me.

dns/py-pywdns/Makefile
13

Yes, that's much better, thanks.

This revision is now accepted and ready to land.Apr 2 2015, 11:26 PM