Adding dependencies when crates are detected
AbandonedPublic
Actions

Authored by pizzamig on Sep 23 2019, 9:10 AM.

Details

Reviewers

Group Reviewers

Summary

Currently, cargo.mk automatically detects crates that needs further configuration and/or dependencies.
However, same crates injects their dependencies, while other are only providing CARGO_ENV configuration.

This patch has the goal to uniform the situation, always injecting the needed dependencies.

While here, adding llvm as dependency for bindgen

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 26640
Build 25014: arc lint + arc unit

Event Timeline

pizzamig created this revision.Sep 23 2019, 9:10 AM

Harbormaster completed remote builds in B26639: Diff 62454.Sep 23 2019, 9:10 AM

pizzamig edited the summary of this revision. (Show Details)Sep 23 2019, 9:14 AM

pizzamig added reviewers: rust, tobik.

No, all of this is wrong for the reasons given in the commit message of rP499149.

This revision now requires changes to proceed.Sep 23 2019, 9:17 AM

tobik added inline comments.Sep 23 2019, 9:21 AM

Mk/Uses/cargo.mk
175–180	Ports cannot depend on meta ports per rP496150. I also think it is a bad idea to add this for bingen per the reason given in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240725.

Use LLVM_DEFAULT to specify llvm dependency

Harbormaster completed remote builds in B26640: Diff 62455.Sep 23 2019, 9:32 AM

OK, I was unsure which direction was the right one, but I've seen the inconsistency and I tried to address it.

I'll abandon this patch and I just push the new dependency to the port, where it belongs

Revision Contents
Changeset List

Path

Size

Mk/

Uses/

cargo.mk

9 lines

Diff 62455

View Options

Adding dependencies when crates are detectedAbandonedPublicActions