Page MenuHomeFreeBSD

Relax vflush FORCECLOSE special vnode to only protect devfs vnodes
ClosedPublic

Authored by cse_cem_gmail_com on Feb 27 2015, 4:18 PM.

Details

Summary

The VNASSERT in vflush() FORCECLOSE case is trying to panic early to prevent errors from yanking devices out from under filesystems. After discussion with kib, we probably only care about special vnodes on devfs.

Sponsored by: EMC / Isilon Storage Division

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

cse_cem_gmail_com retitled this revision from to Relax vflush FORCECLOSE special vnode to only protect devfs vnodes.
cse_cem_gmail_com updated this object.
cse_cem_gmail_com edited the test plan for this revision. (Show Details)
cse_cem_gmail_com added a reviewer: kib.
cse_cem_gmail_com updated this object.

Per discussion on IRC. Move extern declaration into sys/vnode.h so we don't need to import devfs.h in vfs_subr.c.

Drop static declaration of vfs_specops entirely; drop static on actual definition.

This revision is now accepted and ready to land.Feb 27 2015, 4:45 PM